From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D8B18DB1F for ; Sat, 22 Nov 2025 17:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763831948; cv=none; b=YxBkXIBODpwU3688alwv6hFikQrdMy6Rh0ziK58FLaOHha3oWnRdufPPUDQ96EWsayjM5gUYZdy2cFwDj+jQx1q6t+1oukryqfQRmB0k5Rq2PGSkimuHnq7owPpWfxzur5f6pjyZG8O4tiiTX95/mpa73nX6ccTPOUm1SCZsNA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763831948; c=relaxed/simple; bh=YdVcIwGwKDh/6sNNooTobnWdLRFBymQDy/hqcAiUbLg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KKacpC81zJfeaIJP2SHs25sLQ3R36+1ucRXz35Hl0GsizuTH2Bef317PggtFOcU044Y7Lz9UUuBXt1v9txHE8ytYq3ZdtJchReJqL0A+6b3F5O6dAqYCG/R3ZYJ5PfvDLi0eHA7LMSWPjOpMF8Iay7qqHA7VM89jSdnLO10U0JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TlWVCnM4; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlWVCnM4" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-298250d7769so22736705ad.0 for ; Sat, 22 Nov 2025 09:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763831946; x=1764436746; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=YdVcIwGwKDh/6sNNooTobnWdLRFBymQDy/hqcAiUbLg=; b=TlWVCnM4nTfqURfZsmDv7A+sN4t+k5G0hkw315A6YvKGECZcoJIvTGAZIUt6Xx73Br 91ZBfUFBJlO2ItrUb7yTjcPLErT6a+yUEQ5CPge9iU+5Se7KMyg+pPzwrhaGuyht0R3T 2WBYZhw+ZktmDRM9aDX+WR7hozY9inlax+gpwojdL79D9IVBiQMgsXDdO8HynVpFwRZA g6zCPAFgkBCozbU/3vOaaWDFtU/MBFY2DcAXHvISPe8FxyPQTs2Mui6FOf2eCC/IYZKh iQ5QjrpYuMRaHiIyoD5jvHRg3AEXYh3sRQzSYwko5JfTVKG9P8QEwD5Pk7A+7g8IHuN3 VD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763831946; x=1764436746; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YdVcIwGwKDh/6sNNooTobnWdLRFBymQDy/hqcAiUbLg=; b=iR5Kn3H7EKKXaSe2avzjYd77cBWY17GLXKfYjtTQJ+pUG36M2Xedthhr4PBm09sRTf n7ec2FgWR24W7IZsjW376ln+5hNMtCQVpapSkSGiV8GH3UX2wT17sgwmTegSoAKdBa91 GCOJdbOicAQM4PkVzc0Fw/CbCS4fkU9LILw3VezVx8/I4VIWLFKwJ3hh8KdyhykBXXUC 0bRkFIQTwHihhJdYZvK3T4dzQkGyLqnJB24D924Isleaodv7fSJlHWNNhvBmWvb4liIw wEllxn7QVA3c9OeoNUtg74Ho2KmuqLaHVtea4E2so1NOFDocvQ++Hydfj6Vuqi3SCB1n kJiA== X-Forwarded-Encrypted: i=1; AJvYcCVnimLw1y1Y9jpjkYYbVTr4bwEQT0237bzof8eskoW/hrqLXMkiEGVen+Mjh/LutZnOoHWi9E0llQ8TSLw=@vger.kernel.org X-Gm-Message-State: AOJu0YztPSuxQyzTQz0nKGPHsG9D+NiGJTgcqePsgl82AzL/tyDt+vC2 mdu3Susxr4M0m1ZBCXdY623DCKEZyInCFyZfMjMlg3gRH6ZNyYr55YJs X-Gm-Gg: ASbGncvi/ft8eIlt/sVtOK5hkn/+/+Czzn10ZGbGoUn2VrbH2U3umtVwSiHVuAp6boc Z308VMnGp8WteNKAT1OqBr8xS9BcFnaty3P6Oai6v+5fz/XhLH8C/HWtBqM5Buyd7RXGmqF50QU Cwqt/AGWOkBvCpLws6jfyfUtdTuUSFleFxcObMk19gDbV1OTMrHgZ2UyzAgZ8kqi1uyzs1gRKIO cJOPY+05MTAHd8sxX9U3qwC2+eilkoyOmSa5lPdnX6NZFzySl1mIFrKhIqZAvmr+vf/ADnNhYJd K1xunxlva3OtaYOEMSqvs9PFgBO4+7XsNSgKdmHZo7D1HjY1rC+Ktvhx1DAZmdnjkIkO1OnhHou d3xT1NTiEjjevtVn2e3aBbpEXZyJp7HLL+Py73v8AFsDNKcMhGRLHdLXxAhcQKJWvPTzzrt/tCY XS9Besrgw5ddKW3QPTxhLd9dA4oGv2id8oIqd7Agq49RtHAunMNVQVtpPxjQ== X-Google-Smtp-Source: AGHT+IHsrLiktElDl4VpBRWD7TSKCwrK/iXEsY4HhXbo8d2kQN4F0sY+95g5j41nDQTVNYF7qGlfkg== X-Received: by 2002:a17:903:2c06:b0:290:94ed:184c with SMTP id d9443c01a7336-29b6c3e86acmr69614135ad.15.1763831946402; Sat, 22 Nov 2025 09:19:06 -0800 (PST) Received: from ?IPv6:2401:4900:8fcd:4575:1ad3:3d1a:3314:cdd0? ([2401:4900:8fcd:4575:1ad3:3d1a:3314:cdd0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024b7c5sm9536723b3a.43.2025.11.22.09.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 09:19:05 -0800 (PST) Message-ID: Subject: Re: [PATCH v2] crypto: asymmetric_keys: fix uninitialized pointers with free attribute From: ally heev To: Krzysztof Kozlowski , David Howells , Lukas Wunner , Ignat Korchagin , Herbert Xu , "David S. Miller" Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Date: Sat, 22 Nov 2025 22:49:00 +0530 In-Reply-To: <531dba90-247e-481a-a26b-2dc9e7927d6d@kernel.org> References: <20251111-aheev-uninitialized-free-attr-crypto-v2-1-33699a37a3ed@gmail.com> <531dba90-247e-481a-a26b-2dc9e7927d6d@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-11-22 at 15:25 +0100, Krzysztof Kozlowski wrote: > On 11/11/2025 14:36, Ally Heev wrote: > > Uninitialized pointers with `__free` attribute can cause undefined > > behavior as the memory assigned randomly to the pointer is freed > > automatically when the pointer goes out of scope. > >=20 > > crypto/asymmetric_keys doesn't have any bugs related to this as of now, > > but, it is better to initialize and assign pointers with `__free` > > attribute in one statement to ensure proper scope-based cleanup > >=20 > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ > > Signed-off-by: Ally Heev > > --- > > Changes in v2: > > - moved declarations to the top and initialized them with NULL >=20 > Why? This is not the syntax we want for cleanup.h. Either initialize it > with proper constructor or don't use cleanup.h. >=20 >=20 > Best regards, > Krzysztof This is the only one I missed reverting :( (after the disc=C2=A0https://lore.kernel.org/lkml/58fd478f408a34b578ee8d949= c5c4b4da4d4f41d.camel@HansenPartnership.com/) Regards, Ally