mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Marcel Hellwig <mhellwig@mut-group.com>,
	'Eric Dumazet' <eric.dumazet@gmail.com>,
	David Laight <David.Laight@ACULAB.COM>,
	"'davem@davemloft.net'" <davem@davemloft.net>,
	"'kuznet@ms2.inr.ac.ru'" <kuznet@ms2.inr.ac.ru>,
	"'yoshfuji@linux-ipv6.org'" <yoshfuji@linux-ipv6.org>,
	"'andrew@lunn.ch'" <andrew@lunn.ch>
Cc: "'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	Matthias Wystrik <mwystrik@mut-group.com>
Subject: Re: AW: AW: PROBLEM: Kernel Oops in UDP stack
Date: Thu, 2 Aug 2018 08:07:11 -0700	[thread overview]
Message-ID: <b297c600-1600-3560-7f2e-6d504529e0db@gmail.com> (raw)
In-Reply-To: <18341daf5b2c458db8e30299d6cddafc@ZCOM03.mut-group.com>



On 08/02/2018 06:57 AM, Marcel Hellwig wrote:
>>> There are actually 2 faults, difficult to quickly sort out the merged tracebacks.
>>> You are also running a rather old kernel: Linux version 3.4.113.
>>>
>>> It may well be that whichever ethernet driver generated the misaligned 
>>> frame has since been fixed.
>>
>> A misalign frame driver problem would have faulted earlier in IP stack, much before we perform the copy to user space in udp_recvmsg()
>>
> 
> JFYI: we are talking about the lpc_eth driver[0] #57c10b6 , which is not the newest, but all newer did not fix a major problem (at least the commit messages are not screaming: WARNING, UNALIGNED MEMORY!). Is there a diagram/document how a ip packet travels down the code? From the MAC/phy driver to udp_recvmsg? It's not that obvious for me, but maybe it is something I can work with.
> 
> 
> [0]: https://elixir.bootlin.com/linux/v3.4.113/source/drivers/net/ethernet/nxp/lpc_eth.c
> 
> Regards,
> Marcel
> 


Well, this driver does not use NET_IP_ALIGN reservation, meaning IP header is not 4-byte aligned.

No idea why mis-alignments are okay in IP layer, but not in UDP

You could try to patch it to use netdev_alloc_skb_ip_align() instead of dev_alloc_skb()


  reply	other threads:[~2018-08-02 15:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 15:06 Marcel Hellwig
2018-07-31 15:59 ` Eric Dumazet
2018-08-01  5:55   ` AW: " Marcel Hellwig
2018-08-01 10:20     ` Eric Dumazet
2018-08-01 10:35       ` AW: " Marcel Hellwig
2018-08-01 10:44         ` Paolo Abeni
2018-08-01 10:49           ` Eric Dumazet
2018-08-01 11:25             ` Eric Dumazet
2018-08-01 11:31               ` AW: " Marcel Hellwig
2018-08-01 13:27                 ` Marcel Hellwig
2018-08-02 11:02                   ` Marcel Hellwig
2018-08-02 13:05                     ` Eric Dumazet
2018-08-02  9:17         ` David Laight
2018-08-02 13:13           ` Eric Dumazet
2018-08-02 13:18             ` David Laight
2018-08-02 13:57             ` AW: " Marcel Hellwig
2018-08-02 15:07               ` Eric Dumazet [this message]
2018-08-03  8:24                 ` AW: " Marcel Hellwig
2018-08-07 13:42                   ` Marcel Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b297c600-1600-3560-7f2e-6d504529e0db@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhellwig@mut-group.com \
    --cc=mwystrik@mut-group.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®