From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mfd: asic3: Delete redundant variable definition
Date: Fri, 3 Apr 2020 10:11:04 +0200 [thread overview]
Message-ID: <b2a0e5f6-1f07-a7bd-2f3c-c95119efe635@web.de> (raw)
> In this function, 'ret' is always assigned, even if 'pdata->leds'
> don't carry out,
I notice possibilities again to improve such a commit message.
> it has already been assigned a value in the above code, including '0',
The variable assignment will eventually be performed only in if branches.
> so it's redundant.
I suggest to reconsider this interpretation of the source code here.
Would you like to move the mentioned statement into an else branch
at the end?
Regards,
Markus
next reply other threads:[~2020-04-03 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:11 Markus Elfring [this message]
2020-04-03 9:25 ` Lee Jones
2020-04-03 10:12 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 4:20 [PATCH] mfd:asic3:Delete " Tang Bin
2020-04-16 7:08 ` Lee Jones
2020-04-16 9:57 ` Tang Bin
2020-04-17 9:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a0e5f6-1f07-a7bd-2f3c-c95119efe635@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®