From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216F6C433ED for ; Thu, 6 May 2021 02:17:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F29B5613BE for ; Thu, 6 May 2021 02:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbhEFCSf (ORCPT ); Wed, 5 May 2021 22:18:35 -0400 Received: from mga18.intel.com ([134.134.136.126]:59048 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbhEFCSe (ORCPT ); Wed, 5 May 2021 22:18:34 -0400 IronPort-SDR: bD/uPtSENMGzJE3zvXxa4fnN+B01ddwZzalDZc/Wg9TxAV5xA/yN3lQ1u0NKrgjY6bpC4Gk9Jo DGWnBpERQ94g== X-IronPort-AV: E=McAfee;i="6200,9189,9975"; a="185818877" X-IronPort-AV: E=Sophos;i="5.82,276,1613462400"; d="scan'208";a="185818877" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 19:17:36 -0700 IronPort-SDR: 0eZjQhvS6wTzEm3/NX5QFvAAa6wepwUsPJ6bLS570U94Oi/9qIAKC81WdKkmVaK3zhDoOWmYK2 9hb7OfBZub9g== X-IronPort-AV: E=Sophos;i="5.82,276,1613462400"; d="scan'208";a="434112674" Received: from unknown (HELO [10.238.4.82]) ([10.238.4.82]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 19:17:31 -0700 Subject: Re: [PATCH v1 1/2] perf header: Support HYBRID_TOPOLOGY feature To: Arnaldo Carvalho de Melo , Jiri Olsa Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <20210430074602.3028-1-yao.jin@linux.intel.com> From: "Jin, Yao" Message-ID: Date: Thu, 6 May 2021 10:17:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On 5/5/2021 9:49 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, May 04, 2021 at 09:37:34PM +0200, Jiri Olsa escreveu: >> On Tue, May 04, 2021 at 04:28:33PM -0300, Arnaldo Carvalho de Melo wrote: >>> Em Tue, May 04, 2021 at 04:56:44PM +0200, Jiri Olsa escreveu: >>>> On Fri, Apr 30, 2021 at 03:46:01PM +0800, Jin Yao wrote: >>>>> It would be useful to let user know the hybrid topology. >>>>> Adding HYBRID_TOPOLOGY feature in header to indicate the >>>>> core cpus and the atom cpus. >>> >>>>> With this patch, >>> >>>>> For the perf.data generated on hybrid platform, >>>>> reports the hybrid cpu list. >>> >>>>> root@otcpl-adl-s-2:~# perf report --header-only -I >>>>> ... >>>>> # cpu_core cpu list : 0-15 >>>>> # cpu_atom cpu list : 16-23 >>> >>>> hum, should we print 'hybrid:' or something to make >>>> sure its not confused with something else? like >>> >>>> # hybrid cpu_core cpu list : 0-15 >>>> # hybrid cpu_atom cpu list : 16-23 >>> >>> But this _core/_atom already got to be enough? I disagreed with that >>> naming, but neverthless having one or the other present in an output is >>> a clear mark of this hybrid topology. >>> >>> I.e having that extra hybrid string that wouldn't add information to the >>> output. >> >> sure when you know that cpu_core/cpu_atom are hybrid pmus ;-) >> and I guess other arch will come with other names > > Yeah, its too Intel centric, I thought they would come up with > cpu_big/cpu_little and map it to core/atom on Intel and whatever other > BIG/little arches come up with. > > Perhaps: > > root@otcpl-adl-s-2:~# perf report --header-only -I > ... > # hybrid cpu system: > # cpu_core cpu list : 0-15 > # cpu_atom cpu list : 16-23 > > ? > That's a good idea! :) On my ADL test machine, it's now output like: # hybrid cpu system: # cpu_core cpu list : 0-15 # cpu_atom cpu list : 16-23 Thanks Jin Yao > - Arnaldo >