mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <i.bornyakov@metrotek.ru>, <Conor.Dooley@microchip.com>
Cc: <mdf@kernel.org>, <hao.wu@intel.com>, <yilun.xu@intel.com>,
	<trix@redhat.com>, <linux-fpga@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry
Date: Thu, 28 Jul 2022 19:18:54 +0000	[thread overview]
Message-ID: <b2ae744c-990f-a432-7cd5-b7e1e440ad4e@microchip.com> (raw)
In-Reply-To: <20220728184650.6wa5zwbrciatfsba@x260>



On 28/07/2022 19:46, Ivan Bornyakov wrote:
> On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
>> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
>> programming driver.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>>  drivers/fpga/microchip-spi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
>> index bd284c7b8dc9..7436976ea904 100644
>> --- a/drivers/fpga/microchip-spi.c
>> +++ b/drivers/fpga/microchip-spi.c
>> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
>>  module_spi_driver(mpf_driver);
>>  
>>  MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
>> +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
>>  MODULE_LICENSE("GPL");
>> -- 
>> 2.36.1
>>
> 
> Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> 
> Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
> submitted a couple of other drivers without it, should I fix them?
> 

It'll show up in modinfo. I don't think it's a big deal though.
/shrug
Conor.

      reply	other threads:[~2022-07-28 19:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28  7:50 Conor Dooley
2022-07-28 12:29 ` Tom Rix
2022-08-15  3:28   ` Xu Yilun
2022-07-28 18:46 ` Ivan Bornyakov
2022-07-28 19:18   ` Conor.Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2ae744c-990f-a432-7cd5-b7e1e440ad4e@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=hao.wu@intel.com \
    --cc=i.bornyakov@metrotek.ru \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®