From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53483C433DF for ; Mon, 29 Jun 2020 23:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BB4020780 for ; Mon, 29 Jun 2020 23:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728210AbgF2XqC (ORCPT ); Mon, 29 Jun 2020 19:46:02 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:55510 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726751AbgF2XqB (ORCPT ); Mon, 29 Jun 2020 19:46:01 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 543F54E9FF7E02924904; Mon, 29 Jun 2020 16:00:09 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 29 Jun 2020 16:00:07 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: remove useless parameter of __insert_free_nid() To: Liu Song , , CC: , , References: <20200628134813.37192-1-fishland@aliyun.com> From: Chao Yu Message-ID: Date: Mon, 29 Jun 2020 16:00:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200628134813.37192-1-fishland@aliyun.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/6/28 21:48, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song > > In current version, @state will only be FREE_NID. This parameter > has no real effect so remove it to keep clean. > > Signed-off-by: Liu Song Reviewed-by: Chao Yu Thanks,