From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Walker Chen <walker.chen@starfivetech.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 1/3] dt-bindings: dma: snps,dw-axi-dmac: constrain resets items for JH7110 dma
Date: Tue, 7 Mar 2023 10:03:52 +0100 [thread overview]
Message-ID: <b2b36909-b0b1-7507-3145-141eb5ec0f3f@linaro.org> (raw)
In-Reply-To: <20230306140430.28951-2-walker.chen@starfivetech.com>
On 06/03/2023 15:04, Walker Chen wrote:
> The DMA controller needs two reset items to work properly on JH7110 SoC,
> so there is need to constrain the items' value to 2, other platforms
> have 1 reset item at most.
>
> Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
> ---
> .../bindings/dma/snps,dw-axi-dmac.yaml | 24 +++++++++++++++----
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index ad107a4d3b33..d8b5439f215c 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -12,14 +12,12 @@ maintainers:
> description:
> Synopsys DesignWare AXI DMA Controller DT Binding
>
> -allOf:
> - - $ref: "dma-controller.yaml#"
> -
> properties:
> compatible:
> enum:
> - snps,axi-dma-1.01a
> - intel,kmb-axi-dma
> + - starfive,jh7110-axi-dma
>
> reg:
> minItems: 1
> @@ -58,7 +56,8 @@ properties:
> maximum: 8
>
> resets:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> snps,dma-masters:
> description: |
> @@ -109,6 +108,23 @@ required:
> - snps,priority
> - snps,block-size
>
> +allOf:
> + - $ref: "dma-controller.yaml#"
Rebase your patches on something recent... I would argue that it should
be based on maintainer's (or linux-next) tree, but that would be too
good to be true.
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - starfive,jh7110-axi-dma
> + then:
> + properties:
> + resets:
> + minItems: 2
What are the items expected here?
> + else:
> + properties:
> + resets:
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-07 9:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 14:04 [PATCH v4 0/3] Add DMA driver for StarFive JH7110 SoC Walker Chen
2023-03-06 14:04 ` [PATCH v4 1/3] dt-bindings: dma: snps,dw-axi-dmac: constrain resets items for JH7110 dma Walker Chen
2023-03-07 9:03 ` Krzysztof Kozlowski [this message]
2023-03-07 10:30 ` Walker Chen
2023-03-07 15:51 ` Krzysztof Kozlowski
2023-03-08 1:08 ` Walker Chen
2023-03-06 14:04 ` [PATCH v4 2/3] dmaengine: dw-axi-dmac: Add support for StarFive JH7110 DMA Walker Chen
2023-03-06 14:39 ` Emil Renner Berthing
2023-03-07 1:38 ` Walker Chen
2023-03-06 14:04 ` [PATCH v4 3/3] riscv: dts: starfive: add dma controller node Walker Chen
2023-03-06 14:51 ` Emil Renner Berthing
2023-03-07 1:40 ` Walker Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b36909-b0b1-7507-3145-141eb5ec0f3f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®