From: John Garry <john.garry@huawei.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"brian.starkey@arm.com" <brian.starkey@arm.com>,
"olof@lixom.net" <olof@lixom.net>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"minyard@acm.org" <minyard@acm.org>,
"xuwei (O)" <xuwei5@hisilicon.com>
Subject: Re: [PATCH v9 5/7] ACPI: Translate the I/O range of non-MMIO devices before scanning
Date: Fri, 30 Jun 2017 10:28:36 +0100 [thread overview]
Message-ID: <b2bc9134-9944-bd6a-2daf-8f1a1ff49a62@huawei.com> (raw)
In-Reply-To: <20170630090515.GU629@lahna.fi.intel.com>
On 30/06/2017 10:05, Mika Westerberg wrote:
> On Thu, Jun 29, 2017 at 05:16:15PM +0100, John Garry wrote:
>> On 16/06/2017 12:24, Rafael J. Wysocki wrote:
>>>>>>>>>
>>>>>>>>> It causes acpi_default_enumeration() to be called but it should be fine
>>>>>>>>> as we are dealing with platform device anyway.
>>>>>>>
>>>>>>> I do not quite understand how declaring such MFD cell above would make sure
>>>>>>> that the LPC probe is called before the IPMI device is enumerated...
>>>>>
>>>>> In fact it may be that it is not sufficient in this case because the
>>>>> ACPI core might enumerate child devices before the LPC driver even gets
>>>>> a chance to probe so you would need to add also scan handler to the
>>>>> child devices and mark them already enumerated or something like that.
>>> Or extend the special I2C/SPI handling to them.
>>>
>>
>> For this, is it possible to just configure the ACPI table so we spoof that
>> the LPC slave (IPI0001), is an i2c/spi slave? Could we just add a resource
>> of type ACPI_RESOURCE_TYPE_SERIAL_BUS, and common serial bus type i2c/spi to
>> solve this?
>
> But is the device connected to a I2C or SPI bus? If not, then it does
> not make much sense to declare it as I2C or SPI slave. Instead it should
> be platform device which is the type we use when there is no explicit
> bus specified in ACPI.
>
No, it's not a SPI nor an I2C bus. I actually would say that my idea is
generally wrong, as the ACPI definition is not a real reflection of the
bus/slave.
However, Rafael did suggest extending special I2C/SPI handling to them.
In this case, I don't see how the LPC slave can be identified like an
I2C or SPI slave is.
Thanks,
John
> .
>
next prev parent reply other threads:[~2017-06-30 9:30 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 11:37 [PATCH v9 0/7] LPC: legacy ISA I/O support Gabriele Paoloni
2017-05-25 11:37 ` [PATCH v9 1/7] LIB: Introduce a generic PIO mapping method Gabriele Paoloni
2017-05-26 20:57 ` Bjorn Helgaas
2017-05-30 15:09 ` Gabriele Paoloni
2017-05-25 11:37 ` [PATCH v9 2/7] PCI: Apply the new generic I/O management on PCI IO hosts Gabriele Paoloni
2017-05-26 21:20 ` Bjorn Helgaas
2017-05-30 8:12 ` Gabriele Paoloni
2017-05-25 11:37 ` [PATCH v9 3/7] OF: Add missing I/O range exception for indirect-IO devices Gabriele Paoloni
2017-05-25 11:37 ` [PATCH v9 4/7] LPC: Support the device-tree LPC host on Hip06/Hip07 Gabriele Paoloni
2017-05-25 11:37 ` [PATCH v9 5/7] ACPI: Translate the I/O range of non-MMIO devices before scanning Gabriele Paoloni
2017-05-26 0:03 ` kbuild test robot
2017-05-30 13:24 ` Lorenzo Pieralisi
2017-05-31 10:24 ` Gabriele Paoloni
2017-06-06 8:55 ` Lorenzo Pieralisi
2017-06-12 15:57 ` Lorenzo Pieralisi
2017-06-13 7:24 ` Gabriele Paoloni
2017-06-13 8:48 ` Mika Westerberg
2017-06-13 14:38 ` Gabriele Paoloni
2017-06-13 15:10 ` Mika Westerberg
2017-06-13 19:01 ` Gabriele Paoloni
2017-06-13 20:03 ` Mika Westerberg
2017-06-15 18:01 ` Gabriele Paoloni
2017-06-16 8:33 ` Mika Westerberg
2017-06-16 11:24 ` Rafael J. Wysocki
2017-06-16 12:00 ` Mika Westerberg
2017-06-16 12:22 ` Rafael J. Wysocki
2017-06-19 9:50 ` Gabriele Paoloni
2017-06-19 10:02 ` Mika Westerberg
2017-06-19 10:04 ` Gabriele Paoloni
2017-07-03 16:08 ` Gabriele Paoloni
2017-07-03 16:23 ` Gabriele Paoloni
2017-07-03 20:22 ` Andy Shevchenko
2017-07-04 15:14 ` Gabriele Paoloni
2017-07-04 15:46 ` Andy Shevchenko
2017-07-04 16:22 ` Gabriele Paoloni
2017-06-29 16:16 ` John Garry
2017-06-30 9:05 ` Mika Westerberg
2017-06-30 9:28 ` John Garry [this message]
2017-06-30 12:56 ` Rafael J. Wysocki
2017-05-25 11:37 ` [PATCH v9 6/7] LPC: Add the ACPI LPC support Gabriele Paoloni
2017-05-26 3:12 ` kbuild test robot
2017-05-26 10:12 ` Gabriele Paoloni
2017-05-25 11:37 ` [PATCH v9 7/7] MANTAINERS: Add maintainer for HiSilicon LPC driver Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2bc9134-9944-bd6a-2daf-8f1a1ff49a62@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=brian.starkey@arm.com \
--cc=catalin.marinas@arm.com \
--cc=frowand.list@gmail.com \
--cc=gabriele.paoloni@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=minyard@acm.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®