From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05796C7113E for ; Fri, 18 Aug 2023 12:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376846AbjHRMWp (ORCPT ); Fri, 18 Aug 2023 08:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376823AbjHRMWN (ORCPT ); Fri, 18 Aug 2023 08:22:13 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FF7E30F5 for ; Fri, 18 Aug 2023 05:22:11 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4fe1b00fce2so1166300e87.3 for ; Fri, 18 Aug 2023 05:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692361329; x=1692966129; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Anar2tjwy/nKg+s1vkJ6uTXJO/Hb9Dx22ZtKE9tT+8c=; b=ile5Q6cIlfvtubyp6Z7BHRCPZmE0+l0/R3Rv3Dl8elnIfdoWvxy2WQdmwAbPVlkUfR ILPreCdJjiuZaAfhexuCLKaLkrGLNLtCo1Hp4qJGLEa/YmgQGDge6NmjIkA8JKEH3cCO 5wlFEpCMC6FSRmJGTkOg02LGSLfgdEQL9Eow5/ezpu430MN8RkQpj3rGt0Im9bCITftu DDtJx9DUaQd3Urq3Iu6wj07aUVbJ/Nc7EQLvVFDv3WQXQS/Is57aDEmqBRabuQxfQnam nxArZylYyJdd/sexNzoNXJ5VK8LknSgMRlye7PX0CDlz1gXfFkj4yeK3wpjqErgm6C7J DaZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692361329; x=1692966129; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Anar2tjwy/nKg+s1vkJ6uTXJO/Hb9Dx22ZtKE9tT+8c=; b=Rbquu7QvDHHcLJYUuQYvePxAINAET7siAFOQcxLvyMVcdQC1CH9E4AUlL7N5FJK502 PcZvL2Upz/a6PmLBb8GIEKHcTpLsBLRRXPHdCW6M/iG+fbbx1IUXjfDldGjOpBFaLmuA AgbRl9XrPswuFB0fz5xBCKeA2zQoxDuCwHU5mFolGUQbU/Gwzfyic1YccXHPVvnLRk/g PpKimjAmNfx16/jncEOrUFFzBF1jVOK+6k+dgIxv1AFdxM+VlGcrENgpmCHFcAEFlAwp QqKdzmjIMzU69+/D+ywztj4TArKhVSour3ahdQrhkv8FXIjgIHv/Ibu0CQ+qCIT130lb NkRw== X-Gm-Message-State: AOJu0Yxi0imnixer3SPHEGUze68br/TkGXG7IPXawy/2mRkhnInSYucV H9CVTgALUVyRmYv60f5FPnxw0Q== X-Google-Smtp-Source: AGHT+IEEf2Bcd73pO4OiJcwoKu5dGzgSJ+M4jI+DqDHBxOF4FOBYxsGC7UiYBYPAaCiPLE/5q/VJSQ== X-Received: by 2002:a05:6512:3a89:b0:4f8:56cd:da8c with SMTP id q9-20020a0565123a8900b004f856cdda8cmr1558312lfu.34.1692361329572; Fri, 18 Aug 2023 05:22:09 -0700 (PDT) Received: from [192.168.1.101] (abxh52.neoplus.adsl.tpnet.pl. [83.9.1.52]) by smtp.gmail.com with ESMTPSA id q27-20020ac2511b000000b004ffa0350851sm329171lfb.78.2023.08.18.05.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Aug 2023 05:22:09 -0700 (PDT) Message-ID: Date: Fri, 18 Aug 2023 14:22:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/13] media: qcom: camss: Start to move to module compat matched resources Content-Language: en-US To: Bryan O'Donoghue , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230817143812.677554-1-bryan.odonoghue@linaro.org> <20230817143812.677554-3-bryan.odonoghue@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20230817143812.677554-3-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.08.2023 16:38, Bryan O'Donoghue wrote: > There is a lot of unnecessary if/elsing in this code that arguably > should never have made it upstream when adding a second let alone > subsequent SoC. > > I'm guilty of not fixing the mess myself when adding in the sm8250. > Before adding in any new SoCs or resources lets take the time to cleanup > the resource passing. > > First step is to pass the generic struct camss_resources as a parameter > per the compatible list. > > Subsequent patches will address the other somewhat dispirate strutures > which we are also doing if/else on and assigning statically. > > Squashed down a commit to drop useless NULL assignment for ispif resources. > > Signed-off-by: Bryan O'Donoghue > --- Acked-by: Konrad Dybcio Konrad