From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF574C07545 for ; Tue, 24 Oct 2023 08:21:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233670AbjJXIV4 (ORCPT ); Tue, 24 Oct 2023 04:21:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbjJXIVy (ORCPT ); Tue, 24 Oct 2023 04:21:54 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B102299 for ; Tue, 24 Oct 2023 01:21:31 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5ac88d2cfaaso3293580a12.2 for ; Tue, 24 Oct 2023 01:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1698135691; x=1698740491; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HUo6nBDSjHnWxlBYRXP9wvzcVcvr9aSoPVi9khaxylQ=; b=Kb6BXI4QgZ7xPLow1JYc2OaFq4/PbC7AJbBpZbaepuRaJYkyIEqQrZTYFNnIlmvI7d aQYqOJBrj7FtZgsD1O2Lcq/XF45Kk0I47yleg6bKvERdXp0Vu440L/iiJS5IYL1vrth5 qbQoJEpZiqC11v9DhWYRhar94KhULRBbG2zefgatzCCADkCYNA7kTcTW3IFwIXxVAe/Q rXceJy+7WY/4zSwtPZFQYoztLADv55XYQMz4ubLypldzIZyIE/0F1zWujm4uOtWTA8lx Mbo8SIkHlPxLY/UGIAdi0VjmsBEGodbojUAf1/BOJdTNteCkjbgqoe/cH8UarjMUZXMk Blmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698135691; x=1698740491; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HUo6nBDSjHnWxlBYRXP9wvzcVcvr9aSoPVi9khaxylQ=; b=KTJmKLSgwHAr/tZV3I+59K6Zgs7UkrJeLmXcGBZog3DyENcWQ3y7FMh5wFf/b7oWiD vrdD1STK15Ikj/XraVUzjhTP/zRJicbwiE+eMEJS/aSS0WSCRpTONvpRaGUgCVopu4E+ J3AVtng0m7d/O7Zyk2Kop7VbI14ee4Tb9D1UjB4x0hWziMYivtGYLG0Ezbot+kMpY/JY YEHAn08rakfVTAe3WbxIQ/6FJMjdYov4BRvCigLzQF/tfhSbev4O7yzdqL92wjdJGZz1 e67IFjbq8pcLWWWKNt/4mUC5J+XionLKAlwUGEvPnMoDz2edgfWfIeUuHmwsOhSlxBe1 QC9Q== X-Gm-Message-State: AOJu0YzhnqJIx3gao29oJdIcBjCcVZEilfZDaqJpTSpA5ATA0r7Fl7Mi pRpQpLlVGohCrLM4tv/lbQrCyA== X-Google-Smtp-Source: AGHT+IHbILyu6kZBKayDDb4NnoqcCDA4V3hXD153HR0lhVyDjX8ZUOVIYiA3+aqhk3W6AOa8Rx4r+A== X-Received: by 2002:a05:6a21:a109:b0:15d:e68d:a850 with SMTP id aq9-20020a056a21a10900b0015de68da850mr1519205pzc.29.1698135691165; Tue, 24 Oct 2023 01:21:31 -0700 (PDT) Received: from [10.84.152.177] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id fb22-20020a056a002d9600b006be17e60708sm7200680pfb.204.2023.10.24.01.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 01:21:30 -0700 (PDT) Message-ID: Date: Tue, 24 Oct 2023 16:21:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Re: [PATCH net v3 3/3] sock: Ignore memcg pressure heuristics when raising allocated To: Paolo Abeni , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Shakeel Butt Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231019120026.42215-1-wuyun.abel@bytedance.com> <20231019120026.42215-3-wuyun.abel@bytedance.com> <69c50d431e2927ce6a6589b4d7a1ed21f0a4586c.camel@redhat.com> Content-Language: en-US From: Abel Wu In-Reply-To: <69c50d431e2927ce6a6589b4d7a1ed21f0a4586c.camel@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/23 3:08 PM, Paolo Abeni Wrote: > On Thu, 2023-10-19 at 20:00 +0800, Abel Wu wrote: >> Before sockets became aware of net-memcg's memory pressure since >> commit e1aab161e013 ("socket: initial cgroup code."), the memory >> usage would be granted to raise if below average even when under >> protocol's pressure. This provides fairness among the sockets of >> same protocol. >> >> That commit changes this because the heuristic will also be >> effective when only memcg is under pressure which makes no sense. >> So revert that behavior. >> >> After reverting, __sk_mem_raise_allocated() no longer considers >> memcg's pressure. As memcgs are isolated from each other w.r.t. >> memory accounting, consuming one's budget won't affect others. >> So except the places where buffer sizes are needed to be tuned, >> allow workloads to use the memory they are provisioned. >> >> Signed-off-by: Abel Wu >> Acked-by: Shakeel Butt >> Acked-by: Paolo Abeni > > It's totally not clear to me why you changed the target tree from net- > next to net ?!? This is net-next material, I asked to strip the fixes > tag exactly for that reason. Sorry I misunderstood your suggestion.. > > Since there is agreement on this series and we are late in the cycle, I > would avoid a re-post (we can apply the series to net-next anyway) but > any clarification on the target tree change will be appreciated, > thanks! Please apply to net-next. Thanks! Abel