From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Teddy Astie <teddy.astie@vates.tech>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
David Woodhouse <dwmw2@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] x86/xen/pv: Don't setup runstate area too early
Date: Fri, 16 Oct 2026 18:33:53 +0100 [thread overview]
Message-ID: <b2c02327-4d77-4ab3-855c-26b5d357f348@citrix.com> (raw)
In-Reply-To: <1792170392.8631fc262581453bbf619ec5b2062170.1a145adfbff0008425@vates.tech>
On 16/10/2026 6:06 pm, Teddy Astie wrote:
> This is no longer required since [1].
>
> At this moment of boot, per_cpu areas are not initialized, which prevents
> using VCPUOP_register_runstate_phys_area as per_cpu_ptr_to_phys() would
> misbehave in this case.
This isn't really correct.
The per-cpu area for the BSP is within the main image, which is why the
logic functions today. What's missing is the call to
pcpu_setup_first_chunk() which tells per_cpu_ptr_to_phys() about where
the BSP data is.
I think you want to say:
"A future change wants to use per_cpu_ptr_to_phys() in
xen_setup_runstate_info(), but this call is too early. It turns out to
be no longer required since ..."
>
> [1] 8a22b9996b00 ("xen: drop xen_sched_clock in favour of using plain wallclock time")
> ---
Missing SoB.
~Andrew
next parent reply other threads:[~2026-10-16 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1792170295.8631fc262581453bbf619ec5b2062170.1a145ac82530008425@vates.tech>
[not found] ` <1792170392.8631fc262581453bbf619ec5b2062170.1a145adfbff0008425@vates.tech>
2026-10-16 17:33 ` Andrew Cooper [this message]
2026-10-16 18:04 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c02327-4d77-4ab3-855c-26b5d357f348@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dwmw2@infradead.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=teddy.astie@vates.tech \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®