From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BE5C433DF for ; Thu, 18 Jun 2020 05:47:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA5D62100A for ; Thu, 18 Jun 2020 05:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbgFRFrk (ORCPT ); Thu, 18 Jun 2020 01:47:40 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:52128 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbgFRFrj (ORCPT ); Thu, 18 Jun 2020 01:47:39 -0400 Received: from [37.162.76.16] (port=34618 helo=[192.168.43.3]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1jlnOg-000Fdz-JC; Thu, 18 Jun 2020 07:47:34 +0200 Subject: Re: [PATCH 4/5] dt-bindings: fpga: xilinx-slave-serial: add optional INIT_B GPIO To: Rob Herring , Moritz Fischer Cc: linux-fpga@vger.kernel.org, Michal Simek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin References: <20200611211144.9421-1-luca@lucaceresoli.net> <20200611211144.9421-4-luca@lucaceresoli.net> <20200617223955.GA2967317@bogus> From: Luca Ceresoli Message-ID: Date: Thu, 18 Jun 2020 07:47:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200617223955.GA2967317@bogus> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Moritz, On 18/06/20 00:39, Rob Herring wrote: > On Thu, Jun 11, 2020 at 11:11:43PM +0200, Luca Ceresoli wrote: >> The INIT_B is used by the 6 and 7 series to report the programming status, >> providing more control and information about programming errors. >> >> Signed-off-by: Luca Ceresoli >> --- >> .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> index 9f103f3872e8..a049082e1513 100644 >> --- a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> @@ -16,6 +16,10 @@ Required properties: >> - prog_b-gpios: config pin (referred to as PROGRAM_B in the manual) >> - done-gpios: config status pin (referred to as DONE in the manual) >> >> +Optional properties: >> +- init_b-gpios: initialization status and configuration error pin >> + (referred to as INIT_B in the manual) > > Don't use '_' in property names: > > init-b-gpios OK, will fix. Moritz, please don't apply this version of patches 4 and 5 if you still haven't done so. Now what about the existing prog_b-gpios property? Should we just leave it as is for backward compatibility, or is there a migration path to fix it as well? Thanks. -- Luca