From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0F541A91D for ; Wed, 15 Jul 2026 10:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110022; cv=none; b=M7jRuNW0WU07ZxvpIgyTPKJxyrMSnWbJN4lrsCe23bqjBdVTllDnZ4iD22fOBVxIV45CCqIf/PnYbH5ODF+YM0Qwd0gazpFyN/bPNnzCVrYAMD+94kD7naM8V07SOPg8vxIQ81G8vuiiMAm0h9Fvgdt+2fp1zAmPxy5uqz3JT2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110022; c=relaxed/simple; bh=HAknQiUL7XmRLQU4Bw0HEheq0vCOHeI8MTqdQuWXrJY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bE62jpica432FD/qZaFHlyyfBg3hNcRuDffhoSyDsPEuVuzoAM5KIrQN9CtiWNY1RpU1BFpfE+vTCSd7s7wZLEdBR/kBWUspAEFt0+AamqIRNjdkaNnz7hhs6lxxCe0e4pqvKIYf2g1N9XkxOP0R4dkW9a19Tr94L/WxAbTa6OY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gOQitf0p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CagMcTMP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gOQitf0p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CagMcTMP" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66FA5Jpn2621007 for ; Wed, 15 Jul 2026 10:07:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hQuytmltyngSmdwciRLeAa8lJF709BV73bAM1g2asUs=; b=gOQitf0psHkK472z B58sZHZ3a2Nv9ynQxMuMekcpdfsA3KJH2kpv7IGqX0THVoyE54smidNvUzZadzOS AavaQ8y8g60KVbAvZiKOONpzyVMJvnbjknY8/JMwX41q3JLOtOOuMFHqVeK4vHzw YT1fSfciLfydzVICHzu5DNVzLbijH6uZT7mgea5jHW7VIpuZr5YzSXmbO0FwCID2 rkrmkWkPlCnZitEfKoDTtCczy3lBmyM1eu/xj7+ibC/RzUL0V3ZQUgASLn9pRjK3 Hs4yNkFWDQ2VBqEsL7hJ2o0bc+hujiUVCFzfTfAjehxCCrA16cwZo9hSjMVEo/YU 2HZd6A== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fe03vhqu0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 10:07:00 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e69a569ffso104243785a.2 for ; Wed, 15 Jul 2026 03:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784110020; x=1784714820; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hQuytmltyngSmdwciRLeAa8lJF709BV73bAM1g2asUs=; b=CagMcTMPWgpOsSPKkfnG7NjBmht7eVaP5xGxOluTTG/E/657KIvceGEwOmum40GvYw K1NA+O6rRp1MEPTugo/+WxMtdFPFLXmd8zApRdW0aN8XZrCMJzjUAzo2vwv4LMzeRjnc 3pwYSmEgQglqCDo3FPSdI5Nz0/GjTDzLi5nHbMak2e4ctG13A0hzxgxsPljU1UVQwGkm 5eAPetzSX0OLAVwA+5pj5iWDjMWTaS50q2D9h5wSKwKH2ztYl07bnBSJmX8Zo1QzFeAl noNdjVR1MSRIwwZI9vnOlvnsYaJidg7wjYDVwHWSP7Yj0COcqlR0jyX2Lu0BlZ6flvTG 9OdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784110020; x=1784714820; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hQuytmltyngSmdwciRLeAa8lJF709BV73bAM1g2asUs=; b=K7FbRiiJv2rb2WXt6ojiGqLH+8z8in7Ke77phtMQtWpgHMPYoZGt/uefXvMOhU2vt+ GaUhX8qVJ+HHdcVLcZhXapHaLDuvPF/Woc7O65ZgJK+iCe3xzMC5shhcqrU1lCA2sWOn PHfDbI5xMIvY0iz5EjyRRQi9kkQaA3iYjdUDQIMOSXmW6Tppvb670v5crozSIRnahJJT xUTMst9fvUnCkzOKCXojXkIYQ3FocEQUf8rh3J+2k9RjnqvuknQSfZ5JJ5NJGJ2QRXdf mImWvACvtJt0OzBgaIiwYcgllZnEQYIUQPbsjIUILCpeA/F+cFvm3JqBtwmJNc3MFRHR SbEA== X-Forwarded-Encrypted: i=1; AHgh+RqVylWhy8j3700z2nnqTGbinZxImjdmw/SlVZVT9LAxKWNWFohBAWHpDvxkLbDdzGkqTWJG9HNx6GjmGDA=@vger.kernel.org X-Gm-Message-State: AOJu0YyCIGgCF+ncKYeYFst1B2SdgCkl7P2hVCLdUvj1MjQWiwY/myvs uTag+F/9ImnwsiZYUPw8fGIe2WvQ4ZEWtGeaseq/d4iw5eOQCqObYrywKvF6vRDg1co8DLvTH1z qW0ok0clIE7PBkn6CzajJ2F4WRVT5yPf+hCC8sVOxSg6gO33Mpkfym5rOAjwJEfuFeOc= X-Gm-Gg: AfdE7cmsJl7g6adPNEpytcVyB+SaIs1udpBBvb2ARukvznUbLZeEIldFlczNtLTR1Fr xCG9GVyH4TEMWHtsesxRIQRRZZ++qO9D+oKeStzhfLQwEGaQHI5UsgBZqXhQgm+oocLMaTZtNTS 01A0p6ojYJpfOVucLAgRv++t2QdC1414HQKflAZAOo+9Y2DVhvcTWSNW+f90UdXYH5x/dxWG1iN DymfdF24Is16xgBpBjy2omHpccG/rGB6/sz1712MmDtzGCtXaGxI9khhsrvk+fLU+r1xHqHApd1 NGmM6xIUm+eh0HYh+7n0CDIYfmAKRvJM16lCBEdgdOKLnJX8ATvjxZqs0t+b0OoGcL6/r1LRZtG DegREEGQoTJ7q40AMe8RmaYQrD18WR8l6IW4= X-Received: by 2002:a05:620a:460c:b0:92e:5023:78b with SMTP id af79cd13be357-92ef2c1a94amr1335844385a.5.1784110020080; Wed, 15 Jul 2026 03:07:00 -0700 (PDT) X-Received: by 2002:a05:620a:460c:b0:92e:5023:78b with SMTP id af79cd13be357-92ef2c1a94amr1335841085a.5.1784110019543; Wed, 15 Jul 2026 03:06:59 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15d4bffdbesm1081919566b.45.2026.07.15.03.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 03:06:58 -0700 (PDT) Message-ID: Date: Wed, 15 Jul 2026 12:06:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] ASoC: codecs: lpass-va-macro: check clk_set_rate() return value To: Ajay Kumar Nandam , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-0-f0c713ff0b4e@oss.qualcomm.com> <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-2-f0c713ff0b4e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-2-f0c713ff0b4e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ife3n2qa c=1 sm=1 tr=0 ts=6a575bc4 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=YT72Ugdk_NjNlKIGY0EA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: Ra64R5Moth9WZGAGrBopkuk1CYxQeLfq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDA5OCBTYWx0ZWRfXxQU8Ssow4gKn 6e2FjlgIOSdhXrEMdmbyqXWFcT/sKTPBFxr6qY0EvAukm6IUvdbM5wgVNX4/pS1w1qTF8VnDZb0 R3+gXmbbwzyHOv5skDwxhF8WO2jByvZag32F9S2v+jfQJyZawjHOc07bNTYYSMQQCZdzwooB/aD opZBoUQB7Sy0MBgeUL/c2fMfEr+552TAXJR5VPQ6YFgA8b+4SWaHifqIqDSrnauBtkcyZP7yvAF yE6bfQ1YXyaEC6L9FAQcnpmecygpl3R9BwQn+0FeNVBfcHIvV+q1MuD+uhB0I8VzoAUxJ6vntLG 1BAi9+tE025CFdHSaU5rqdtOXEWIHHlSs4yowj2W0w2uyZnCe0tSLppuVupqOR023QgcwQeL0Su 13vQgaN+D6Fd69nehKScGQXojsjavzs8Ag/W1Cu4Fe2GiivfCt1ZhUOW/j30i1jKEjCFpaZiSmc GVETtY8UlbnOcEB9fpQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDA5OCBTYWx0ZWRfX7TI0qYNe98YT YpYbDRRXqKFTyGHJ2ktnBzL32J/awyQyA9gGEyf1AvNPdsvr/JP2GY84hP0sXpS/1qTwiYVdG7d dOclANaNxP6Y0GRIiVMz2fEOs6nDyj4= X-Proofpoint-GUID: Ra64R5Moth9WZGAGrBopkuk1CYxQeLfq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150098 On 7/15/26 10:29 AM, Ajay Kumar Nandam wrote: > clk_set_rate() returns 0 on success or a negative errno on failure but > the VA macro probe function was ignoring it. Check the return value and > bail out of probe on failure. > > Signed-off-by: Ajay Kumar Nandam > --- Reviewed-by: Konrad Dybcio Konrad