From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "beanhuo@micron.com" <beanhuo@micron.com>,
"mani@kernel.org" <mani@kernel.org>,
"can.guo@oss.qualcomm.com" <can.guo@oss.qualcomm.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: ufs: core: Avoid possible memory reclaim deadlock in TX EQTR context
Date: Tue, 16 Jun 2026 10:35:50 +0000 [thread overview]
Message-ID: <b2c5b74f8becddf68cbe87d390459a43e542570b.camel@mediatek.com> (raw)
In-Reply-To: <20260616090654.421850-1-can.guo@oss.qualcomm.com>
On Tue, 2026-06-16 at 02:06 -0700, Can Guo wrote:
> TX EQTR may run while devfreq gear scaling has quiesced the UFS
> tagset. In
> that context, functions ufshcd_tx_eqtr(), __ufshcd_tx_eqtr() and
> ufs_qcom_get_rx_fom() allocate memory with GFP_KERNEL. If direct
> reclaim
> is triggered, reclaim/writeback can depend on I/O to UFS device.
> Because
> the queue is quiesced, this can cause deadlock.
>
> Use GFP_NOIO for TX EQTR memory allocations:
> - params->eqtr_record in ufshcd_tx_eqtr()
> - eqtr_data in __ufshcd_tx_eqtr()
> - params in ufs_qcom_get_rx_fom()
>
> Fixes: 03e5d38e2f98 ("scsi: ufs: core: Add support for TX
> Equalization")
> Closes:
> https://urldefense.com/v3/__https://sashiko.dev/*/patchset/20260615132834.2985346-1-can.guo@oss.qualcomm.com?part=2__;Iw!!CTRNKA9wMg0ARbw!mkZe-Src0MPmBc2cQbRZtnVJptXP26uI7g0q9gx5ARTkkm9rC-F2eyWzO_fkKvjCDwwJh7a89OZHIGvcx_KbdwM$
> Signed-off-by: Can Guo <can.guo@oss.qualcomm.com>
> ---
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2026-06-16 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 9:06 Can Guo
2026-06-16 10:35 ` Peter Wang (王信友) [this message]
2026-06-16 13:31 ` Bart Van Assche
2026-06-17 8:44 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c5b74f8becddf68cbe87d390459a43e542570b.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=can.guo@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®