From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C20C2BB1D for ; Tue, 17 Mar 2020 11:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 434AD2051A for ; Tue, 17 Mar 2020 11:24:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbgCQLYS (ORCPT ); Tue, 17 Mar 2020 07:24:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:60184 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbgCQLYR (ORCPT ); Tue, 17 Mar 2020 07:24:17 -0400 IronPort-SDR: igUf7PrRvcVZYtrBcC7AldeQFQT/WF7NOy1PKKXTvLrTL5V6owCXz9ZdgRu3Zy5tjQc6gur0nm MAYFTrEkiuYg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 04:24:17 -0700 IronPort-SDR: ym6w+YD+WLAOsiXsFcvr5v46k0vFcKq96Aou1QarGV9ROUv4IsFiEbJRpjHzHKHaKO5BzHhBCO Z1NOXwKA/GeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,564,1574150400"; d="scan'208";a="244448946" Received: from xiaoyaol-mobl.ccr.corp.intel.com (HELO [10.255.31.237]) ([10.255.31.237]) by orsmga003.jf.intel.com with ESMTP; 17 Mar 2020 04:24:13 -0700 Subject: Re: [PATCH] KVM: X86: correct meaningless kvm_apicv_activated() check To: Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov Cc: linmiaohe@huawei.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1584185480-3556-1-git-send-email-pbonzini@redhat.com> <878sk0n1g1.fsf@vitty.brq.redhat.com> <20200316152650.GD24267@linux.intel.com> <87zhcgl2xc.fsf@vitty.brq.redhat.com> <20200316155911.GE24267@linux.intel.com> From: Xiaoyao Li Message-ID: Date: Tue, 17 Mar 2020 19:24:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/2020 12:39 AM, Paolo Bonzini wrote: > On 16/03/20 16:59, Sean Christopherson wrote: >>>> >>> if (!!old == !!new) >>> return; >>> >>> to make it clear we're converting them to 1/0 :-) >> >> All I can think of now is the Onion article regarding razor blades... >> >> if (!!!!old == !!!!new) >> return; >> > > That would be !!!!!, but seriously I'll go with two. > > (Thanks for giving me a chuckle, it's sorely needed these days). Take care, Paolo. I have been staying at home for two months in Wuhan, China, and things are going better now. I believe all the world can defeat Coronavirus eventually. > Paolo >