From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ruud Derwig <Ruud.Derwig@synopsys.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Jos van Eijndhoven <Jos.vanEijndhoven@synopsys.com>
Subject: Re: [PATCH] arc: vdk: Fix support of UIO
Date: Thu, 23 Mar 2017 10:37:51 -0700 [thread overview]
Message-ID: <b2d81e8a-b2d0-0eb0-295a-f91fb58f4563@synopsys.com> (raw)
In-Reply-To: <1490290485-16332-1-git-send-email-abrodkin@synopsys.com>
+CC Jos !
-Vineet
On 03/23/2017 10:34 AM, Alexey Brodkin wrote:
> MotherBoard section has its "ranges" set to 0xE000_0000-0xF000_0000.
> But UIO node maps 4 different areas in different memory locations
> and all outside MB's ranges.
>
> That obviously breaks UIO mappings in runtime.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: Ruud Derwig <rderwig@synopsys.com>
> Cc: stable@vger.kernel.org
> ---
> arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
> index f0df59b23e21..459fc656b759 100644
> --- a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
> @@ -112,13 +112,19 @@
> interrupts = <7>;
> bus-width = <4>;
> };
> + };
>
> - /* Embedded Vision subsystem UIO mappings; only relevant for EV VDK */
> - uio_ev: uio@0xD0000000 {
> - compatible = "generic-uio";
> - reg = <0xD0000000 0x2000 0xD1000000 0x2000 0x90000000 0x10000000 0xC0000000 0x10000000>;
> - reg-names = "ev_gsa", "ev_ctrl", "ev_shared_mem", "ev_code_mem";
> - interrupts = <23>;
> - };
> + /*
> + * Embedded Vision subsystem UIO mappings; only relevant for EV VDK
> + *
> + * This node is intentionally put outside of MB above becase
> + * it maps areas outside of MB's 0xEz-0xFz.
> + */
> + uio_ev: uio@0xD0000000 {
> + compatible = "generic-uio";
> + reg = <0xD0000000 0x2000 0xD1000000 0x2000 0x90000000 0x10000000 0xC0000000 0x10000000>;
> + reg-names = "ev_gsa", "ev_ctrl", "ev_shared_mem", "ev_code_mem";
> + interrupt-parent = <&mb_intc>;
> + interrupts = <23>;
> };
> };
next prev parent reply other threads:[~2017-03-23 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:34 Alexey Brodkin
2017-03-23 17:37 ` Vineet Gupta [this message]
2017-03-24 20:35 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2d81e8a-b2d0-0eb0-295a-f91fb58f4563@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Jos.vanEijndhoven@synopsys.com \
--cc=Ruud.Derwig@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®