mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "M, Krishnamoorthi" <krishnamoorthi.m@amd.com>
To: Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, Raju.Rangoju@amd.com,
	Weibin Liu <liuwb@xiaopeng.com>
Cc: linux-kernel@vger.kernel.org, sanju.mehta@amd.com,
	stable@vger.kernel.org, Guanglei Zhu <zhugl3@xiaopeng.com>
Subject: Re: [PATCH] spi: amd: fix len==0 underflow and FIFO overflow
Date: Fri, 16 Oct 2026 17:46:29 +0530	[thread overview]
Message-ID: <b2d9229d-2f34-4a1c-b288-9332917c3b8e@amd.com> (raw)
In-Reply-To: <179210311701.134795.14035717437104935583.b4-ty@b4>

Hi Mark,

On 10/16/2026 3:55 AM, Mark Brown wrote:
> On Wed, 14 Oct 2026 20:39:13 +0800, Weibin Liu wrote:
>> spi: amd: fix len==0 underflow and FIFO overflow
> 
> Applied to
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.4
> 
> Thanks!
> 

I sent review comments in parallel without seeing the apply mail - 
they're not a blocker, just a minor improvement.

The applied change is already memory-safe; the rx FIFO bound is just 
checked after amd_spi_execute_opcode(), so an oversized message drives 
one transaction before being rejected. Since the patch is applied, the 
change can be taken in a follow-up patch.


Thanks,
Krishna

  reply	other threads:[~2026-10-16 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 12:39 Weibin Liu
2026-10-15 22:25 ` Mark Brown
2026-10-16 12:16   ` M, Krishnamoorthi [this message]
2026-10-16 11:27 ` M, Krishnamoorthi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2d9229d-2f34-4a1c-b288-9332917c3b8e@amd.com \
    --to=krishnamoorthi.m@amd.com \
    --cc=Raju.Rangoju@amd.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=liuwb@xiaopeng.com \
    --cc=sanju.mehta@amd.com \
    --cc=stable@vger.kernel.org \
    --cc=zhugl3@xiaopeng.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®