From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Kathiravan T <quic_kathirav@quicinc.com>,
andersson@kernel.org, agross@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock
Date: Mon, 17 Apr 2023 16:34:32 +0200 [thread overview]
Message-ID: <b2ddefb6-78e1-1c25-00de-3512b9f76b6d@linaro.org> (raw)
In-Reply-To: <20230417105607.4091-1-quic_kathirav@quicinc.com>
On 17.04.2023 12:56, Kathiravan T wrote:
> The order of DT_SLEEP_CLK and DT_XO are swapped and it is incorrect.
> Due to which the clocks for which the parent should be XO is having parent
> as SLEEP_CLK and vice versa. So fix the same by re-ordering the entries.
>
> Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
> Reported-by: Devi Priya <quic_devipriy@quicinc.com>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
This matches what I can see in the bindings.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes in V2:
> - Added the Reported-by and Fixes tag
>
> drivers/clk/qcom/gcc-ipq5332.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index 8cacbfb10c72..14096887d436 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -20,8 +20,8 @@
> #include "reset.h"
>
> enum {
> - DT_SLEEP_CLK,
> DT_XO,
> + DT_SLEEP_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK_X1,
> DT_USB_PCIE_WRAPPER_PIPE_CLK,
next prev parent reply other threads:[~2023-04-17 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 10:56 Kathiravan T
2023-04-17 14:34 ` Konrad Dybcio [this message]
2023-05-12 16:04 ` Kathiravan T
2023-05-27 1:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ddefb6-78e1-1c25-00de-3512b9f76b6d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kathirav@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®