From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 172F011CA9 for ; Mon, 20 Jul 2026 19:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784575500; cv=none; b=GS2tENlF2MGaKSBirrhHIQaSKb5S1dI8QKId9EtLs7l3is8eoLGKmJCKN/YPFswQAPuVjoFr6BA/E7bEK2EWhfuLXnCDhpa/lzQ15ebh4/UNkv/H7WTUhC+8RdwtHGFaxZ8qWi398OkzUEPRd7/cfD/dykIIFB4JPkq8mN0uFwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784575500; c=relaxed/simple; bh=jmv02YI047x2xL6OXfQ0v6pTfoWDZauPaF6Dqs8le1M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qUABTQBH5tqeX+XfC0wHRJ6ZO3WVWHVxcuBdFMb1KSPxWzgdQb3pHx/H/hyq8F2B2LmwFWSJbQIH6QgGRoW3b9sgrkn8WuFVpF9xMFfW9prFoF12XEaTVxqZCVp91Q2CThDJCz4MkjegvwRmJHH2d1eEspIEHxE3Gvt9EI6dCwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=K6MY+65p; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="K6MY+65p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1784575497; bh=jmv02YI047x2xL6OXfQ0v6pTfoWDZauPaF6Dqs8le1M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=K6MY+65pr1hcVX1aj8V2TeKS8e9QQ5ekOsZRaE+/XU564qamyoZs0cuAPK0yCcMci P8qG2mOvZl1nehFQOZ5E5nhB74aMOcE1NNrm8PArL/gUmI1j0LdH1OQEVgJoUF53uJ HP5uwKt1lRVIODh/2r3rEhsSZYgtUwDQDp/iOfWNXHsdC2O5ainOdJx6kAwjrLOhMF Gewf2Fb39K7g3LLKtx07sQooh2ECtnfQw6DtxJrNp44IC/gnjZaKjGh1L5mKsMIpwC NAoJq47rU4Vkz+i9zCn9abVd7sLPZRG4tS7x99fDXF29AF43+KS+MDXIN9x/Aic5GC j6I0Junvafq9Q== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id C4A6017E09A3; Mon, 20 Jul 2026 21:24:56 +0200 (CEST) Message-ID: Date: Mon, 20 Jul 2026 22:24:56 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] phy: rockchip: samsung-hdptx: Drop TMDS rate setup workaround To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Thomas_Niederpr=C3=BCm?= , Simon Wright References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-5-ce5e1d456cda@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/20/26 5:19 PM, Dmitry Baryshkov wrote: > On Fri, Jun 12, 2026 at 02:45:24AM +0300, Cristian Ciocaltea wrote: >> Since commit ba9c2fe18c17 ("drm/rockchip: dw_hdmi_qp: Switch to >> phy_configure()") the TMDS rate setup doesn't rely anymore on the >> unconventional usage of the bus width, instead it is managed exclusively >> through the HDMI PHY configuration API. >> >> Drop the now obsolete workaround to retrieve the TMDS character rate via >> phy_get_bus_width() during power_on(). >> >> While at it, get rid of the extra call to rk_hdptx_phy_consumer_put() by >> moving the statement at the end of the function. >> >> Tested-by: Thomas Niederprüm >> Tested-by: Simon Wright >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 27 +++++------------------ >> 1 file changed, 6 insertions(+), 21 deletions(-) >> >> diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c >> index 25bd821cd039..35997087d61c 100644 >> --- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c >> +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c >> @@ -1660,22 +1660,6 @@ static int rk_hdptx_phy_power_on(struct phy *phy) >> enum phy_mode mode = phy_get_mode(phy); >> int ret, lane; >> >> - if (mode != PHY_MODE_DP) { >> - if (!hdptx->hdmi_cfg.rate && hdptx->hdmi_cfg.mode != PHY_HDMI_MODE_FRL) { >> - /* >> - * FIXME: Temporary workaround to setup TMDS char rate >> - * from the RK DW HDMI QP bridge driver. >> - * Will be removed as soon the switch to the HDMI PHY >> - * configuration API has been completed on both ends. >> - */ >> - hdptx->hdmi_cfg.rate = phy_get_bus_width(hdptx->phy) & 0xfffffff; >> - hdptx->hdmi_cfg.rate *= 100; >> - } >> - >> - dev_dbg(hdptx->dev, "%s rate=%llu bpc=%u\n", __func__, >> - hdptx->hdmi_cfg.rate, hdptx->hdmi_cfg.bpc); >> - } >> - >> ret = rk_hdptx_phy_consumer_get(hdptx); >> if (ret) >> return ret; >> @@ -1701,9 +1685,10 @@ static int rk_hdptx_phy_power_on(struct phy *phy) >> rk_hdptx_dp_pll_init(hdptx); >> >> ret = rk_hdptx_dp_aux_init(hdptx); >> - if (ret) >> - rk_hdptx_phy_consumer_put(hdptx, true); >> } else { >> + dev_dbg(hdptx->dev, "%s rate=%llu bpc=%u\n", __func__, >> + hdptx->hdmi_cfg.rate, hdptx->hdmi_cfg.bpc); >> + >> if (hdptx->pll_config_dirty) >> ret = rk_hdptx_pll_cmn_config(hdptx); >> >> @@ -1716,11 +1701,11 @@ static int rk_hdptx_phy_power_on(struct phy *phy) >> else >> ret = rk_hdptx_tmds_ropll_mode_config(hdptx); >> } >> - >> - if (ret) >> - rk_hdptx_phy_consumer_put(hdptx, true); >> } >> >> + if (ret) >> + rk_hdptx_phy_consumer_put(hdptx, true); > > This looks likes an unrelated change. Could you please split it to a > separate commit? Ack. Thanks, Cristian