From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB2AC25B08 for ; Wed, 17 Aug 2022 21:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242270AbiHQVEQ (ORCPT ); Wed, 17 Aug 2022 17:04:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242256AbiHQVEO (ORCPT ); Wed, 17 Aug 2022 17:04:14 -0400 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [IPv6:2001:4b7a:2000:18::165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E75A8B997 for ; Wed, 17 Aug 2022 14:04:11 -0700 (PDT) Received: from [192.168.1.101] (abxi168.neoplus.adsl.tpnet.pl [83.9.2.168]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 78DBD1F425; Wed, 17 Aug 2022 23:04:09 +0200 (CEST) Message-ID: Date: Wed, 17 Aug 2022 23:04:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFT PATCH v2 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> <20220817130342.568396-12-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20220817130342.568396-12-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.08.2022 15:03, Krzysztof Kozlowski wrote: > The TCSR mutex bindings allow device to be described only with address > space (so it uses MMIO, not syscon regmap). This seems reasonable as > TCSR mutex is actually a dedicated IO address space and it also fixes DT > schema checks: > > qcom/sdm845-shift-axolotl.dtb: hwlock: 'reg' is a required property > qcom/sdm845-shift-axolotl.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > --- Not tested on a device, but looks good to the eye: Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 21ed14200986..bd0ec0664283 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -919,12 +919,6 @@ compute-cb@8 { > }; > }; > > - tcsr_mutex: hwlock { > - compatible = "qcom,tcsr-mutex"; > - syscon = <&tcsr_mutex_regs 0 0x1000>; > - #hwlock-cells = <1>; > - }; > - > smp2p-cdsp { > compatible = "qcom,smp2p"; > qcom,smem = <94>, <432>; > @@ -2588,9 +2582,10 @@ ipa: ipa@1e40000 { > status = "disabled"; > }; > > - tcsr_mutex_regs: syscon@1f40000 { > - compatible = "syscon"; > + tcsr_mutex: hwlock@1f40000 { > + compatible = "qcom,tcsr-mutex"; > reg = <0 0x01f40000 0 0x20000>; > + #hwlock-cells = <1>; > }; > > tcsr_regs_1: sycon@1f60000 {