From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbeADRos (ORCPT + 1 other); Thu, 4 Jan 2018 12:44:48 -0500 Received: from vern.gendns.com ([206.190.152.46]:43798 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946AbeADRoq (ORCPT ); Thu, 4 Jan 2018 12:44:46 -0500 Subject: Re: [PATCH v4 3/7] ARM: davinci: fix duplicate clocks To: Sekhar Nori , linux-arm-kernel@lists.infradead.org Cc: Kevin Hilman , Adam Ford , linux-kernel@vger.kernel.org References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-4-git-send-email-david@lechnology.com> From: David Lechner Message-ID: Date: Thu, 4 Jan 2018 11:44:44 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/4/18 5:12 AM, Sekhar Nori wrote: > On Monday 01 January 2018 05:09 AM, David Lechner wrote: >> There are a number of clocks that were duplicated because they are used by >> more than one device. It is no longer necessary to do this since we are >> explicitly calling clk_register_clkdev() for each clock. In da830.c, some >> clocks were using the same LPSC, which would cause problems with reference >> counting, so these are combinded into one clock each. In da850.c the >> duplicate clocks had already been fixed by creating dummy child clocks, so >> these clocks are removed. >> >> Signed-off-by: David Lechner > > If we do end up keeping 2/7, this should be done before that - to avoid > retouching code that was just introduced. > FWIW, this can't be done before because it will cause broken linked lists in the davinci clocks. But, as I mentioned already, I am going to try a different approach, so this patch will go away completely.