From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932464AbdEKXur (ORCPT ); Thu, 11 May 2017 19:50:47 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42422 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755154AbdEKXuq (ORCPT ); Thu, 11 May 2017 19:50:46 -0400 Subject: Re: [PATCH v2] sound: Disable the build of OSS drivers To: Takashi Iwai , alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jaroslav Kysela , Linus Torvalds References: <20170511205827.16446-1-tiwai@suse.de> From: Randy Dunlap Message-ID: Date: Thu, 11 May 2017 16:50:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170511205827.16446-1-tiwai@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/17 13:58, Takashi Iwai wrote: > OSS drivers are left as badly unmaintained, and now we're facing a > problem to clean up the hackish set_fs() usage in their codes. Since > most of drivers have been covered by ALSA, and the others are dead old > and inactive, let's leave them RIP. > > This patch is the first step: disable the build of OSS drivers. > We'll eventually drop the whole codes and clean up later. > > Signed-off-by: Takashi Iwai Tested-by: Randy Dunlap > --- > > v1->v2: Smaller changes, as Linus and Randy suggested. > The first dmasound Kconfig inclusion is still commented out since > it's shorter/simpler in the end. > > sound/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/Kconfig b/sound/Kconfig > index ee2e69a9ecd1..de23fc39cec8 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -54,7 +54,7 @@ config SOUND_OSS_CORE_PRECLAIM > > If unsure, say Y. > > -source "sound/oss/dmasound/Kconfig" > +# source "sound/oss/dmasound/Kconfig" > > if !M68K && !UML > > @@ -115,6 +115,7 @@ endif # SND > menuconfig SOUND_PRIME > tristate "Open Sound System (DEPRECATED)" > select SOUND_OSS_CORE > + depends on BROKEN > help > Say 'Y' or 'M' to enable Open Sound System drivers. > > -- ~Randy