From: quic_zijuhu <quic_zijuhu@quicinc.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: <marcel@holtmann.org>, <johan.hedberg@gmail.com>,
<luiz.dentz@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<luiz.von.dentz@intel.com>, <linux-kernel@vger.kernel.org>,
<linux-bluetooth@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: hci_sync: Remove redundant func definition
Date: Fri, 15 Jul 2022 15:47:01 +0800 [thread overview]
Message-ID: <b2e97620-bdad-a323-cd07-20e667a8acc6@quicinc.com> (raw)
In-Reply-To: <afbf4b73-29b9-1bca-e5f5-85b7bfdcf568@molgen.mpg.de>
On 7/15/2022 3:34 PM, Paul Menzel wrote:
> Dear Zijun,
>
>
> Thank you for the patch.
>
> Am 15.07.22 um 06:14 schrieb Zijun Hu:
>> both hci_request.c and hci_sync.c have the same definition
>> for disconnected_accept_list_entries(), so remove a redundant
>> copy.
>
> Please use 75 characters per line for Linux commit message bodies. That way, only two instead of three lines are needed.
thanks for your suggestion, correct within v4 sent. could you code review again?
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>> v1->v2
>> -remove the func copy within hci_request.c instead of hci_sync.c
>> net/bluetooth/hci_request.c | 18 ------------------
>> net/bluetooth/hci_request.h | 2 ++
>> net/bluetooth/hci_sync.c | 2 +-
>> 3 files changed, 3 insertions(+), 19 deletions(-)
>
> […]
>
>
> Kind regards,
>
> Paul
prev parent reply other threads:[~2022-07-15 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 4:14 Zijun Hu
2022-07-15 7:34 ` Paul Menzel
2022-07-15 7:47 ` quic_zijuhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e97620-bdad-a323-cd07-20e667a8acc6@quicinc.com \
--to=quic_zijuhu@quicinc.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®