From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdISEDa (ORCPT ); Tue, 19 Sep 2017 00:03:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46190 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdISED2 (ORCPT ); Tue, 19 Sep 2017 00:03:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 626CE6028B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vviswana@codeaurora.org Subject: Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS To: Adrian Hunter , ulf.hansson@linaro.org, will.deacon@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, asutoshd@codeaurora.org, stummala@codeaurora.org, riteshh@codeaurora.org, subhashj@codeaurora.org References: <1504097509-58983-1-git-send-email-vviswana@codeaurora.org> <1504097509-58983-6-git-send-email-vviswana@codeaurora.org> From: Vijay Viswanath Message-ID: Date: Tue, 19 Sep 2017 09:33:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/14/2017 12:04 PM, Adrian Hunter wrote: > On 30/08/17 15:51, Vijay Viswanath wrote: >> Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific >> register read and write APIs, if registered, can be used. > > Missing signed-off > > Why don't you put this patch earlier in the patch set and then you don't > need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ? > This will involve merging the current patches 3 & 4 into one (Some functions defined under ifdef in patch 3 are used only in patch 4). Will that be fine ? >> --- >> drivers/mmc/host/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >> index 2db84dd..64a9298 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM >> tristate "Qualcomm SDHCI Controller Support" >> depends on ARCH_QCOM || (ARM && COMPILE_TEST) >> depends on MMC_SDHCI_PLTFM >> + select CONFIG_MMC_SDHCI_IO_ACCESSORS > > CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS > >> help >> This selects the Secure Digital Host Controller Interface (SDHCI) >> support present in Qualcomm SOCs. The controller supports >> >