From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next v1 1/3] ethtool: Extend cable testing interface with result source information
Date: Tue, 20 Aug 2024 00:03:17 +0200 [thread overview]
Message-ID: <b2ecfecd-997e-40b5-9478-c7b240bf0a21@lunn.ch> (raw)
In-Reply-To: <20240819141241.2711601-2-o.rempel@pengutronix.de>
> @@ -573,15 +573,25 @@ enum {
> ETHTOOL_A_CABLE_RESULT_UNSPEC,
> ETHTOOL_A_CABLE_RESULT_PAIR, /* u8 ETHTOOL_A_CABLE_PAIR_ */
> ETHTOOL_A_CABLE_RESULT_CODE, /* u8 ETHTOOL_A_CABLE_RESULT_CODE_ */
> + ETHTOOL_A_CABLE_RESULT_SRC, /* u32 */
Please follow the convention of given the prefix of values,
ETHTOOL_A_CABLE_INF_SRC_ in the comment. I also wounder if a u8 would
be more in keeping with the API. _PAIR and _CODE are u8.
Andrew
next prev parent reply other threads:[~2024-08-19 22:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 14:12 [PATCH net-next v1 0/3] Add ALCD Support to Cable Testing Interface Oleksij Rempel
2024-08-19 14:12 ` [PATCH net-next v1 1/3] ethtool: Extend cable testing interface with result source information Oleksij Rempel
2024-08-19 22:03 ` Andrew Lunn [this message]
2024-08-19 22:06 ` Andrew Lunn
2024-08-20 0:26 ` Jakub Kicinski
2024-08-19 14:12 ` [PATCH net-next v1 2/3] ethtool: Add support for specifying information source in cable test results Oleksij Rempel
2024-08-19 14:12 ` [PATCH net-next v1 3/3] phy: dp83td510: Utilize ALCD for cable length measurement when link is active Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ecfecd-997e-40b5-9478-c7b240bf0a21@lunn.ch \
--to=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®