From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <beanhuo@iokpp.de>,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, can.guo@oss.qualcomm.com,
ulf.hansson@linaro.org, beanhuo@micron.com,
jens.wiklander@linaro.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices
Date: Tue, 23 Sep 2025 13:27:45 -0700 [thread overview]
Message-ID: <b2ed97b4-bfef-4e4b-83ed-a172214e46e8@acm.org> (raw)
In-Reply-To: <20250923153906.1751813-4-beanhuo@iokpp.de>
On 9/23/25 8:39 AM, Bean Huo wrote:
> + ret = scsi_execute_cmd(sdev, cdb, send ? REQ_OP_DRV_OUT : REQ_OP_DRV_IN,
> + buffer, len, /*timeout=*/30 * HZ, 0, NULL);
> + return ret <= 0 ? ret : -EIO;
scsi_execute_cmd() can return a negative value, zero, or a positive
value. Both negative and positive values should be considered as an
error.
> +MODULE_DESCRIPTION("UFS RPMB integration into the RPMB framework using SCSI Secure In/Out");
That's a very long module description ... Can this description be made
shorter without reducing clarity?
> + u8 rpmb_region0_size;
> + u8 rpmb_region1_size;
> + u8 rpmb_region2_size;
> + u8 rpmb_region3_size;
Why four separate members instead of an array?
Thanks,
Bart.
next prev parent reply other threads:[~2025-09-23 20:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 15:39 [PATCH v1 0/3] " Bean Huo
2025-09-23 15:39 ` [PATCH v1 1/3] rpmb: move rpmb_frame struct and constants to common header Bean Huo
2025-09-23 20:28 ` Bart Van Assche
2025-09-24 6:12 ` Avri Altman
2025-09-25 14:51 ` Bean Huo
2025-09-25 15:45 ` Avri Altman
2025-09-23 15:39 ` [PATCH v1 2/3] scsi: ufs: core: fix incorrect buffer duplication in ufshcd_read_string_desc() Bean Huo
2025-09-23 16:57 ` Bart Van Assche
2025-09-23 15:39 ` [PATCH v1 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-09-23 20:27 ` Bart Van Assche [this message]
2025-09-27 8:40 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ed97b4-bfef-4e4b-83ed-a172214e46e8@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=jejb@linux.ibm.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®