From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33A0A23BF83 for ; Tue, 15 Jul 2025 09:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752573295; cv=none; b=XXHsGpn8JC451r3y/BCitgEpBR2A0NMmw/N7Dkop0e+pwz59sX69wMbK9ZcC3izE8N0E2Ej1dUIsz+CH4Y6ieSnAye0QMq9+dgUTAUHB9MUvXWcsNnccXF+RTsdNqolhq5/DogflarZntvbPBCHlEbnNRYTrsLHdZd6sj2CGiaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752573295; c=relaxed/simple; bh=6OVUx+9AwmAwTG1I+KdQVdAktmQDgN5EP4C7NezIitY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DyuRaSGmUPPll0t/EkEF3lmxxTT88uPJUmHoBCTHuce8PjLZhrdwkijTrfb0VSVjN6bxtCUSDQsqtNd5NHQvsJ7ujUrLgOCvAtRzGNDH1MEX3sRE46CoVYhCFrLLAkebGIkklGb/qwKDn9HYFmHiSo5Rde9B0mLLWNUB+TZEUwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m5YS2BWE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m5YS2BWE" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56F8k9Wg026516 for ; Tue, 15 Jul 2025 09:54:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ix9VuDZeEsjg3KAly3eDP764kZgW3cJT4+AkWYQ4FOg=; b=m5YS2BWEXwTUWNzM Ny0qjTcqmh7VMk3IvJ/ykNqT/s22qqoWpXtCfhf5miRg4FVlyl0mUDLeZ9TwhV1s xlZzwwbxrY7uIayCVQFvkiVbr2k6q4eUARnUz1iej7Qkt8CXRgwywGRUTf7Gdzsj m/Vn2gC0R+I6W54GG7HW2gACmSqqEQnKRzsAudngJqBDDl/muh7QtvQ+WVo/qV+r 9zlGi4ijehAqP0jAv8h0qy49CZFmVd0y16Hmu+3S62TZx5sLnBmFxR3ewPaWtXGx ogXcRleHvisQLl/tlzaQKqi2n8dxZlL2p7qhJtCjcXPhgt3/1R/MS+SLe+gFz7No yi8Aqg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47wkrug91f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 15 Jul 2025 09:54:53 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7deca3ef277so128383685a.1 for ; Tue, 15 Jul 2025 02:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752573292; x=1753178092; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ix9VuDZeEsjg3KAly3eDP764kZgW3cJT4+AkWYQ4FOg=; b=DxVjPdVzNjxINmYoftCdnqaQP62lIftQwlmPh/v8SpuJ6cpqjzOekwQRVeb2/PGgWS aY6qn+TOyXutltR45GiIufxJJ+76k1aP3wvgduwoPcKXs0LemW/cTnPk86aD9O7e9q+C /5YGXnPx5NgMBXqtgPlkne9XXRV+rvqN2YkjJmqxBiRGLY5Bgjmq4RySbOYn5LXPuH0v vCvjn9tuxOObbnIbTvwMxZPUYkfNTWh55sXx9XwY901ZjEQtSea1Ns2y2fSQVwfnCIWE 1UhTDD898bPkN5N0eOckVpgSh52aOwdpyshcHpy1Onw2nCRNYadjPQUvUvXgo/fsBuEX ZNSA== X-Forwarded-Encrypted: i=1; AJvYcCXRWICLOQVIiAuryCSROgkJjqDVWFxI/3mloaWhYxM1C0YUxRhpqkzV98opnebKNzIH9SgNbOpjE0rEonM=@vger.kernel.org X-Gm-Message-State: AOJu0YwIUPRkb11iPRq+HTJ/fjHpwc+oTxguaKmgMgMJZcMwt7KwPLOf Tj00i2pMZhh7sjhU132tDTI8g+14VHViwZmdjuMo+zoBii/Jbg/GN1VQC7khTMGzqcC11FyFV/A Gjs+o2TwB7LUGLkh5R8Rq9iu0Rm8QmOkPP8xvWsEeVXCOcAxv8Iisl7onGWmZGU+ooMhnU236+f M= X-Gm-Gg: ASbGncscrCqa942bQ7gdm8yYMIoMieaII9WwSAzt3Geb0CdjGShB9FQw23azEnUhN30 s5R2oJw9oFZZmvqs3pPcHLDO4EiVcskBHM0BqXY5gUsCcMhd9zc1QELBuE7g/xqkO5pLRc98oFn Ctiul78SJtB3a9ehBm/6/LVcXeboIEO+ZFraG1/e0QllJu8ubtulMP3ZluFkSkgZls/N0lYxGbu th72tOl5VsAVdeGHsvcaWuaevIF2jtdeLyaUxpN2m1RuAh4mL8+msCs24pJxH45bSE7O8vYe/Aq Lk6+l1TpTSzkHhlDwEDfAdAe88mq29kbceRgbIWQXTS8sv0jfS5HpbcLrbT0yOpisyQWTNMgVZu AseVxTcqmbYK0UJDdK0qL X-Received: by 2002:a05:620a:2903:b0:7e3:2c0d:dbf8 with SMTP id af79cd13be357-7e33c6fd95dmr51798185a.2.1752573291743; Tue, 15 Jul 2025 02:54:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDVkaPY/EUoM13O4zdHRmjA+XKRxdgOCmfN0kxQpZ1M/8LP2Xug82sWyuGii3UGqvnwGDvuA== X-Received: by 2002:a05:620a:2903:b0:7e3:2c0d:dbf8 with SMTP id af79cd13be357-7e33c6fd95dmr51797185a.2.1752573291128; Tue, 15 Jul 2025 02:54:51 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df4dasm977493966b.157.2025.07.15.02.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 02:54:50 -0700 (PDT) Message-ID: Date: Tue, 15 Jul 2025 11:54:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] PCI: qcom: Move qcom_pcie_icc_opp_update() to notifier callback To: Manivannan Sadhasivam , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Krishna Chaitanya Chundru References: <20250714-aspm_fix-v1-0-7d04b8c140c8@oss.qualcomm.com> <20250714-aspm_fix-v1-2-7d04b8c140c8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250714-aspm_fix-v1-2-7d04b8c140c8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: gQIVKbMHrEVZX4rCWpbpjN7l6bR7WjS4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE1MDA4OCBTYWx0ZWRfXzjQdZk2DAT5S 3Fo7ImuqUtk07icDy2o0FcZUBkg/2qZyTOLAA0C7e8UOiC8E5Ts7hm2V/0tfydGK6bS9k2W/T9e 8ihTRP41BwxG/56PcvlU6OuLlszRukVkz2OyBeLXp9F0qF3npKXvBYdrzm2QHTGhHfyvxYQ/oBy bVn5uBfCWxD3jEqm1iWZkmQj+NQromPzPqQeu8YIsL83UiBmMoqNsikGBZuVy9liBpGYre3HTt4 LmJfL44KFhnVnwSjXF5RPRbVZE6dASJR0nnrrNtAcUIZKeP5RR5jtG/jJb/wYDYTH8ng6bmHvND qL+D1s4WqaOVd166gQjRGMscZfyXtvoPYZ6rHx0dzA123PILfT01UIS8CQu1zsP924IEwnxNtzA hGb08I50kWOr+LlkKKibwRmxBzs/0YZDLbkgh2s/g7rqPrXD8cwSGV58QE402DvlM/ApjcTP X-Authority-Analysis: v=2.4 cv=WqUrMcfv c=1 sm=1 tr=0 ts=6876256d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=u1rEIhXAyoO4lQmzz6IA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: gQIVKbMHrEVZX4rCWpbpjN7l6bR7WjS4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-15_01,2025-07-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxscore=0 mlxlogscore=996 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507150088 On 7/14/25 8:01 PM, Manivannan Sadhasivam wrote: > It allows us to group all the settings that need to be done when a PCI > device is attached to the bus in a single place. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/controller/dwc/pcie-qcom.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index b4993642ed90915299e825e47d282b8175a78346..b364977d78a2c659f65f0f12ce4274601d20eaa6 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1616,8 +1616,6 @@ static irqreturn_t qcom_pcie_global_irq_thread(int irq, void *data) > pci_lock_rescan_remove(); > pci_rescan_bus(pp->bridge->bus); > pci_unlock_rescan_remove(); > - > - qcom_pcie_icc_opp_update(pcie); > } else { > dev_WARN_ONCE(dev, 1, "Received unknown event. INT_STATUS: 0x%08x\n", > status); > @@ -1765,6 +1763,7 @@ static int pcie_qcom_notify(struct notifier_block *nb, unsigned long action, > switch (action) { > case BUS_NOTIFY_BIND_DRIVER: > qcom_pcie_enable_aspm(pdev); > + qcom_pcie_icc_opp_update(pcie); So I assume that we're not exactly going to do much with the device if there isn't a driver for it, but I have concerns that since the link would already be established(?), the icc vote may be too low, especially if the user uses something funky like UIO Konrad