From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E27A276025 for ; Mon, 8 Jul 2024 10:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720433602; cv=none; b=lqV7OurxoXytVBMh/i08sYfVo8PB079k/v/3E857TLO0WayvNO/byY0Ok2A0+6CnTYKeUdzr4SrA/XHB5hcpqUVLLi3NCUcpRnJJZNJuCOuv1C5zcz2htAinzVxOSpTolvbc/bjzICUj3+ETVPfMn6WB+8kxWLjJgefols9EUNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720433602; c=relaxed/simple; bh=y6dqBqOENd6UqWyt7+MMtufQwArRT0fZ1eNZ2YYAgSc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j8HBqFbJwuVtHT1rOEOJf4YhG02KXHGPFS6SZfD7JLRXY5WaOJZYHcYHwxeTFvbiPnbYlfws3im9+81Os1E2iB9DknGPJC29+Kbvc8ceHbczA5a34IKGNHLAdUEiEtP/3mpgQ0Zhhl1EX0bgra09/lS78qwXsKiYn6gOcuMW5jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ak0UNpGH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ak0UNpGH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720433599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Aq4i8tkGqnPmW+VQcfJOnDtTidOU14j4o+JFRh6Zy9k=; b=ak0UNpGHGfGm81gC8W8HRGT+geLgoufjK3XKFuaDT1bA4g/cU9lMfsUu1Hau23eTjzvPXd HxFCwNjZwX140hTjAixoI8MrUTQaLcNV8gj/kXZwgiGCRKGogSMkrmc2pIDedYm9rWVwwq lxn/+38fGn/rIuvmyehGTGS4EShgcFc= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-RN8xGMwvOneK3Dl430JOWA-1; Mon, 08 Jul 2024 06:13:18 -0400 X-MC-Unique: RN8xGMwvOneK3Dl430JOWA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ee90339092so45930561fa.1 for ; Mon, 08 Jul 2024 03:13:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720433596; x=1721038396; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Aq4i8tkGqnPmW+VQcfJOnDtTidOU14j4o+JFRh6Zy9k=; b=AuNNQxnTkGL2n9GESs0Cp73OJv6ijU7ojgIfGel15qoxSrImDII4TOccOY2y5Aq9c5 5vB/iqaxPNWJ/rlG/LTZ5NdwuqJQzdJgr1lqfXSppIT/o1o6qefoOJbtCFE66NSMv7Do AAfWD42C587RRqsnAKzx/iwbOeuReG2cHrLIMDgv41VmL5UXRk0qxmwLyT2R1ANwefNi MaH2Q6arJy5nTjInu00ZfTBNrNrpuXYDowyY5gfh4UOb6aDo5RpbHpLqGdgHL4q9nAPa 16Bp5lCDAS9LN0fOKUB72u1CpPpcvuiVD3/D/qsB82Guyer4p3xeMrsOUy/WeN81A4YQ gd0Q== X-Forwarded-Encrypted: i=1; AJvYcCWvg+YU825xdwybi1jRC8X/jiNJu2tXQg91U3NYp6g4fATmX+Mi5kUDWu54ikh1x2PqZvuVYsXs14bAbHAjMo/nIyMSegbqGTn1sHUs X-Gm-Message-State: AOJu0YxpUM1ivHcF1M37xwTwXwTKt268j9FX32ywA1L6xZBXl2JP3+0+ gZ68RQkj5bxq74pkTmACp+uqqet5m9seqY2A0KocIKEn4rbOJ91ipQc3hSgD8D4Qi0TKfAzSlYZ GmVH7/JM0/hwdlLIA8prwPT9jbg8UKEhxKwz5D1cnFze+vEXL0SBqrtQs0RudLlkAMhIfE87Z X-Received: by 2002:a05:651c:114b:b0:2ec:3dd4:75f4 with SMTP id 38308e7fff4ca-2ee8edc23d3mr87781801fa.38.1720433596518; Mon, 08 Jul 2024 03:13:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGToWaHMDwnE+0LYJZlu71A2tXExVAesgAxkzanSdp2VXAZygrzzoU3ofCUOmJX18NzvdXxw== X-Received: by 2002:a05:651c:114b:b0:2ec:3dd4:75f4 with SMTP id 38308e7fff4ca-2ee8edc23d3mr87781641fa.38.1720433596129; Mon, 08 Jul 2024 03:13:16 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58de4581536sm5537092a12.16.2024.07.08.03.13.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 03:13:15 -0700 (PDT) Message-ID: Date: Mon, 8 Jul 2024 12:13:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] acpi video: force native for some T2 macbooks To: Aditya Garg , Lukas Wunner , "Rafael J . Wysocki" , Len Brown Cc: "linux-acpi@vger.kernel.org" , Linux Kernel Mailing List , Orlando Chamberlain References: <3DA0EAE3-9EB7-492B-96FC-988503BBDCCC@live.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <3DA0EAE3-9EB7-492B-96FC-988503BBDCCC@live.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 7/5/24 3:56 PM, Aditya Garg wrote: > From: Orlando Chamberlain > > The intel backlight is needed for these, previously users had nothing in > /sys/class/backlight. > > Signed-off-by: Orlando Chamberlain > Signed-off-by: Aditya Garg Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/acpi/video_detect.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 442396f6ed1f..baf7264d7b94 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -513,6 +513,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"), > }, > }, > + { > + .callback = video_detect_force_native, > + /* Apple MacBook Air 9,1 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"), > + }, > + }, > { > /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */ > .callback = video_detect_force_native, > @@ -522,6 +530,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro12,1"), > }, > }, > + { > + .callback = video_detect_force_native, > + /* Apple MacBook Pro 16,2 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,2"), > + }, > + }, > { > .callback = video_detect_force_native, > /* Dell Inspiron N4010 */