From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3W8M=6B=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A1B73C38A29
	for <linux-kernel@archiver.kernel.org>; Fri, 17 Apr 2020 10:56:57 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 8734E21D94
	for <linux-kernel@archiver.kernel.org>; Fri, 17 Apr 2020 10:56:57 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730040AbgDQK44 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 17 Apr 2020 06:56:56 -0400
Received: from szxga07-in.huawei.com ([45.249.212.35]:50316 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1729558AbgDQK4z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Apr 2020 06:56:55 -0400
Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59])
        by Forcepoint Email with ESMTP id 67D31B8AA93247920CBC;
        Fri, 17 Apr 2020 18:56:51 +0800 (CST)
Received: from [127.0.0.1] (10.166.213.7) by DGGEMS405-HUB.china.huawei.com
 (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Apr 2020
 18:56:44 +0800
Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
To:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        <f.fainelli@gmail.com>, <tglx@linutronix.de>,
        <jason@lakedaemon.net>, <maz@kernel.org>, <justinpopo6@gmail.com>,
        <bcm-kernel-feedback-list@broadcom.com>,
        <linux-mips@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Hulk Robot <hulkci@huawei.com>
References: <20200417074036.46594-1-yanaijie@huawei.com>
 <ecb3e3e1-7761-faa7-10fa-67da69604306@cogentembedded.com>
From:   Jason Yan <yanaijie@huawei.com>
Message-ID: <b2f6f8cd-557c-3978-f176-e615cba8b458@huawei.com>
Date:   Fri, 17 Apr 2020 18:56:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <ecb3e3e1-7761-faa7-10fa-67da69604306@cogentembedded.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.166.213.7]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



在 2020/4/17 18:26, Sergei Shtylyov 写道:
> Hello!
> 
> On 17.04.2020 10:40, Jason Yan wrote:
> 
>> Fix the following sparse warning:
>>
>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c 
>> b/drivers/irqchip/irq-bcm7038-l1.c
>> index eb9bce93cd05..fd7c537fb42a 100644
>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops 
>> bcm7038_l1_domain_ops = {
>>       .map            = bcm7038_l1_map,
>>   };
>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>                     struct device_node *parent)
> 
>     Reindent the above line please, it should start under *struct* on 
> the 1st line.

OK, will cook a new one.

> 
> [...]
> 
> MBR, Sergei
> 
> .