From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: zhuyinbo <zhuyinbo@loongson.cn>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>,
wanghongliang@loongson.cn, loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index
Date: Wed, 8 Mar 2023 11:38:16 +0100 [thread overview]
Message-ID: <b2f9cd15-b303-882a-d4e0-36d1f6d155a8@linaro.org> (raw)
In-Reply-To: <ace5159b-ebbd-7805-518c-ed3d39e4793e@loongson.cn>
On 08/03/2023 10:24, zhuyinbo wrote:
>>>> That's an ABI break and commit msg does not explain it.
>>> you meaning is that need add a explanation in commit msg that why
>> You need good explanation to break the ABI. I don't understand the
>> commit msg, but anyway I could not find there justification for ABI
>> break. If you do not have good justification, don't break the ABI,
>
> The commit msg is the patch commit log, and I maybe not got it about
> break the ABI. You said about "break the ABI"
>
> is whether is location issue about "LOONGSON2_BOOT_CLK"? if yes, the
> LOONGSON2_BOOT_CLK was placed
>
> after LOONGSON2_PIX1_PLL that is due to their clock parent is same.
> and I whether need add this explanation
>
> in patch commit log description?
Unfortunately I do not understand single thing from this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 10:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:50 Yinbo Zhu
2023-03-07 11:50 ` [PATCH v13 2/2] clk: clk-loongson2: add clock controller driver support Yinbo Zhu
2023-03-08 12:16 ` kernel test robot
2023-03-09 2:58 ` zhuyinbo
2023-03-09 3:18 ` zhuyinbo
2023-03-09 6:09 ` Krzysztof Kozlowski
2023-03-09 6:27 ` zhuyinbo
2023-03-09 6:37 ` Krzysztof Kozlowski
2023-03-09 6:09 ` Krzysztof Kozlowski
2023-03-09 23:47 ` Stephen Boyd
2023-03-10 8:42 ` Krzysztof Kozlowski
2023-03-13 18:20 ` Stephen Boyd
2023-03-14 1:07 ` zhuyinbo
2023-03-14 6:49 ` Krzysztof Kozlowski
2023-03-15 0:26 ` Stephen Boyd
2023-03-07 12:47 ` [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index Krzysztof Kozlowski
2023-03-08 1:35 ` zhuyinbo
2023-03-08 8:37 ` Krzysztof Kozlowski
2023-03-08 9:24 ` zhuyinbo
2023-03-08 10:38 ` Krzysztof Kozlowski [this message]
2023-03-09 1:43 ` zhuyinbo
2023-03-09 6:25 ` Krzysztof Kozlowski
2023-03-09 12:44 ` zhuyinbo
2023-03-09 16:12 ` Krzysztof Kozlowski
2023-03-10 2:07 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f9cd15-b303-882a-d4e0-36d1f6d155a8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®