From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2962B1CFBA for ; Thu, 16 Apr 2026 04:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776313574; cv=none; b=BRotbuIBx0/VL/62/khHrVV2ivoLK5kFNhJJtQfWFT/0Qz94uRYFlY+f45+YlTs+arn4MRZ0q7ZSEwbSMsExYuqj2+J4/6+q43DHQffFxE7reYNZoIjrcDSce7brG6tNJPkVg2F3BRGglRzcvZykOY+MRea2hN6lV0DOGIFLMqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776313574; c=relaxed/simple; bh=Bk5fdWievPsMhcjVP7ddh39E8mDSDOd9OEYhgtqqb4k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B3L1jtSZ1lR+D8Pt5RNg4X7wSHl1O6UjgdwGII6HP7WdOoMrLNkNxO1GnYp9h72ubLULMGgLBX9Zd3UFTgQAo18mJt7j67bDYRm3jXtWy9Kcq8YxWk8WPOe0P0VhGztyyaJN32AySbnrxfNNSrRAdAr766cvK7xRbq+YL0sLp74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W8R4JkUy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KXYprkkP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W8R4JkUy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KXYprkkP" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G1k2kM2834852 for ; Thu, 16 Apr 2026 04:26:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tOQoMqul5lfLpwYJj4xp+1nJWtaCb5mOonJ6pR8nuv8=; b=W8R4JkUy61RYGS3e HF/1igufJaO7fehXVmzKAak/NglYd+54NrUPvd2/mQdbxvntQd9dXdO/Jev9llUx dJ/K1GOomQrSEaS+4Ziq/RMSj/fgEKpZZydLyjUZZYGqtFiSxF74l7XvMsdTxH8P fMrZQAOQoqeTi6IeSVqKBpb4k9ippCEfyi+UFZyvbQmTsTTpfUKG4Twb7ytdba+E A41JprmK7ynqHo5s7Vdaw1Cn6+CgUgGejKVlDPB7mmIIezY4OGd74mw8Yn8HP48y I7gZWkDgGjM18C4j32YzVX+EY/fgtrcFFdUxTK6fJuBkICvkr5yxKI5VKZezYCHv 8f0NLg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djcsvj7v6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 04:26:12 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3568090851aso17928384a91.1 for ; Wed, 15 Apr 2026 21:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776313572; x=1776918372; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tOQoMqul5lfLpwYJj4xp+1nJWtaCb5mOonJ6pR8nuv8=; b=KXYprkkPQz5m/Tk5xMmK0CcBypSO/FoMUpFxqPoFxo7M2r2cq6VrekM5rIEFASlPJo X83pZHtLhScHv0C5hynoaLZIpTFf4i3dxc6WKjq0eGGNuluf3BAvWbaLf8mz1oK3YkTk iBluo5jrlyYTd5kYIyiZjdALFP/fDkzyBud8ErsamKv41YhCoUduBQmBkK3+HHvo3luZ Obka1C2dr+5dr7IWGlsH6LrT4xKgRBYIcZYj9FphPi0hVf1MqvIf9VxM6OK/OKIxMprf c9yaXSNWuGf6/pFhYb3aFTqvbEKGqRkfmTiozG46wm142rmHAhwiX0jsxMcupLbxA0BV QVMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776313572; x=1776918372; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tOQoMqul5lfLpwYJj4xp+1nJWtaCb5mOonJ6pR8nuv8=; b=s9g87HAEgo1NQoHfvEfa81LFkEcRgytSjhtuNc3okdgOaSrBkCbHE+uVHmBD8dyky1 f3ti80W7I5xJoLazKHcldpmnFkGPLeqJ2a01iTiHdpyJyDCwkK7Ml5CCjAw2E5ptcrzm UxTaCy9t6yqAGcrRe+fPzXvUVNxHYS4mKwlojGRFSkqrshqESFfXe9bI5CgMLJwXfaFU dQiZDWuIglOPQPU9Ezfu7zdKJYq2bONtDxS8LHbjrHoqq8HtCuCdXHkPx4q6HMWxPwpq yoUGsaY5sj6xM5fv0t65TwViMhtQuBP1Q6fSENVPiuKcS213EaFu9lLeZdoij4tswVAk UI5A== X-Forwarded-Encrypted: i=1; AFNElJ86T9t66rFaVnz5Y0SdBv2uunbuVE14MZD8IScxRPV0I+D8ZXZQN8yY3gLEObFayZwR2SaN1vasVfoR3Cs=@vger.kernel.org X-Gm-Message-State: AOJu0YzOmnvhMswsY8gv0uNKUL1OBHU/AaHQ4RDaxd6byXEsk3iKkal9 5JYZoiasjlJTS/Z+BDOtPM61DRf9qZ+SFfVzvEOms0ZYzBZhIL2uO4UdopK0q3HqRZaQYcF+Mw1 w4VxAb0I3s/OSNeBV/ztBEpGseC+UpkcrCrTScAQ3Y08hCIAfXl68BSpM+iPK+KZ0QaA= X-Gm-Gg: AeBDievsBbI8J95P1n/a8EEJs/9OiRkmCXVYAVtLw+nomaYQghLKOvwMPjDZgWJzMYO yRxy8iyDEPRFd39lRs6DB5y8oGGXOMU61cb4USf/NR5IrlMPEy4CDEZ9mrUmGw5PWDHCtmXTj3r 7Pi62ipKP2CYjsno1Hd3O6/ZIsQCIU1uGfw+41ofetFIJUx4Qrfe96whDewMlMHOc3KccS/2oj8 1ukBFRE7UwcdkZFV8kXgpRuBdcFXukeMEO/1GAESdum0HoTrx0a5qgsk9gClVtvbyjeXiBoktT8 EjUQyBoPgVlGSepl3ORi1OTH+Kev6ksTswN6f9IpXyi/THp+Ae/YeSgKpR7KXLOuv4+BVELW7O5 9J1JjKt5v+BT93gc0sZmVAnExlOkcX7c0zeGDb6tBf4M/Iyj2AjM= X-Received: by 2002:a17:90b:3c48:b0:35b:e551:e776 with SMTP id 98e67ed59e1d1-35e42869cbdmr26132163a91.27.1776313571738; Wed, 15 Apr 2026 21:26:11 -0700 (PDT) X-Received: by 2002:a17:90b:3c48:b0:35b:e551:e776 with SMTP id 98e67ed59e1d1-35e42869cbdmr26132135a91.27.1776313571258; Wed, 15 Apr 2026 21:26:11 -0700 (PDT) Received: from [10.217.198.242] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4780f0258sm37692115ad.5.2026.04.15.21.26.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 21:26:10 -0700 (PDT) Message-ID: Date: Thu, 16 Apr 2026 09:56:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] soc: qcom: rpmh: Add support to read back resource settings To: Konrad Dybcio , Kamal Wadhwa , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260407-read-rpmh-v3-v3-0-34079f92691c@oss.qualcomm.com> <20260407-read-rpmh-v3-v3-1-34079f92691c@oss.qualcomm.com> <27c48c9c-32ba-4f92-834e-637dc728c6d3@oss.qualcomm.com> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <27c48c9c-32ba-4f92-834e-637dc728c6d3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: AeXVKPEq_GXk55FMbH4cIx8F8tew8mV- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDAzOSBTYWx0ZWRfX9XPWfixqPTrO xWGravv+ppqZRPSiPzyO1nAKGEaIcsHwWTNb+99Lrd/sduacfT8ibTZt0Z++KADlOzjp6b17Qb8 B1A963khdQBk+OsLXktwaIWdiT4i0oHEzktE06fmJElHeteZqFEdSeKg9X18PRAfygNmsmSDYdf QAAlom+C7ati11Ld6oVUkBa+rjfps/C2shAOZ5fvxiFtSaqUG8o4xVyCiRFHVC8vr6/jWzJVXHp ZZaR/lN3eu8KBTfCWlbBC9yb8iCWndPzA4gXMRZm5fK8dGOtbbeC/IZ9tcK5PvT5nr0UdvL4otj Frkop+cIHqKpzctTwhl5pZRUW5olwbpWs0iLBxrbvwu6zGUWbBrs5JjIMKlnJp3OfDWd1nirI03 Doy30+u5adUihEicognObNL/CEpreamj53UC3lpzT8hUMorAXf2nfBbupa1yZlGbnu6I4aRNMxv w/BInQzYMCjoC75epBw== X-Authority-Analysis: v=2.4 cv=Iby3n2qa c=1 sm=1 tr=0 ts=69e064e4 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=x3goO2KD9uaNahKmKuAA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: AeXVKPEq_GXk55FMbH4cIx8F8tew8mV- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_01,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160039 On 4/7/2026 6:26 PM, Konrad Dybcio wrote: > On 4/7/26 6:43 AM, Kamal Wadhwa wrote: >> From: Maulik Shah >> >> All rpmh_*() APIs so far have supported placing votes for various resource >> settings but the H/W also have option to read resource settings. >> >> Add new rpmh_read() API to allow clients to read back resource setting >> from H/W. This will be useful for clients like regulators, which currently >> don't have a way to know the settings applied during bootloader stage. >> >> Signed-off-by: Maulik Shah >> Signed-off-by: Kamal Wadhwa >> --- > > [...] > >> @@ -453,6 +454,11 @@ static irqreturn_t tcs_tx_done(int irq, void *p) >> >> trace_rpmh_tx_done(drv, i, req); >> >> + if (req->is_read) { >> + reg = drv->regs[RSC_DRV_CMD_RESP_DATA]; >> + req->cmds[0].data = read_tcs_reg(drv, reg, i); > > Does this break if we send a request that contains a read request > at index != 0, or chain multiple read commands? (is that possible?) > > Or perhaps this is fine, because the only way to "legally" send a > read command is rpmh_read() which sends a message with just a single > read command? Yes, the only way currently to send a read command is via rpmh_read() with single read command (placed at index 0) and hence the read is from same index. >From H/W point it is possible to fill in the TCS command at index != 0 and trigger or chain of multiple read command (With something like rpmh_read_batch() API if a use case ever comes up to read multiple resources). Thanks, Maulik > > Otherwise this patch looks good to me > > Konrad >