From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68EDB156F30 for ; Tue, 9 Jul 2024 10:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720521981; cv=none; b=lWDtmE5MQkfORFQkK7ZjTy1MLe+9g4ds+2gbrh1q9XoEwjGxOL4D96Ohhe6vuB55xOvq7llYvQTC8l2rAFwOxBliG6djeubyST80XYh0+BhV0wnZo0OWY2N2MHpOy7HmTdtWiTOs92tPNcVGjeqTCyQp1Zll9WhoOkA58c6sOlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720521981; c=relaxed/simple; bh=5IA8mdGCfwwEyp51ZU+XuuCLP1hY9Wkb5MGpdFIvwmQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=GblGE40v2f+LypaqpSRycm49TZH10BgX9Wyg/Fmm/i0717IBNRDJUn5ZHhDo9Yw8opwWlmii1j2ZmaxQ65J5o3UoNM812Ba/F9Xgn3u13/hl+XDf6On6Wr0M4nxizt9ANmDK1mri6ZWH0izi50wFa8JX49US48K+Y+LKlxTWS0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Gz+Hyk91; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gz+Hyk91" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720521979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GuImmRUsPrPaGPMQUJQBiXamDtmIgFq3/kSekF2cPAA=; b=Gz+Hyk916L81Vpv8p1fAMcfGZ1fyLuqp5HPZJm2tIYorFQvt7nMdWhcQaVm4WnlgZPw6jT UAVkfhHrtGyIZcoK1IDjLhOMTR2hW0aHeO7boxoDIWPPOLMgZXRYCTxUR+pi33PvXvihMw khKJNFaOcYi0zkmY/KSvY5wV7ogWdlI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-sIJ7oiGHPmCtvhn3zlWQ1A-1; Tue, 09 Jul 2024 06:46:17 -0400 X-MC-Unique: sIJ7oiGHPmCtvhn3zlWQ1A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-36794d92c46so172716f8f.3 for ; Tue, 09 Jul 2024 03:46:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720521976; x=1721126776; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GuImmRUsPrPaGPMQUJQBiXamDtmIgFq3/kSekF2cPAA=; b=nTikXXJ9cMoVTtCnvTgMya4fjDaaCr6Llc8BaOhyW1LjEMVIaqFRRCp6APtx4LTmVL NRKDx7ZVOn5QScjVLLMCE5GV+CKmu32mmfIwBbZVGmCLFw8dVMYBmPowLvfcn3S9jJye eHV/hjtWzg163QEoj4Toh2fsQmSTBJV3i289DKqlURksBJsrJuLrWA2Tgc05GyFY1Q5g 6caUSPrwAkk1WR+Uu1DgbVAhtp77t+gfqg+o09kRsJi0tI2LKPmePtN1OuNE/48x1ej1 pvtt5X53fqk7urRP8wE960XWe7Bc4Jy1kv3turGwdOmZF5hU3ve7pm/JPNoM0M5f763F FVbw== X-Forwarded-Encrypted: i=1; AJvYcCXPmVGJPqoABVYKTwy2W8FnL34jNZtBOOyP/eR3kxhfZtA0mx8Noc0MUfgZyoZOmyiclaVEdV48JjpTxoCEbro65Gdn5CjmoFyHsLgf X-Gm-Message-State: AOJu0Yzf+vYNblOgLu+u7srXwYCGmvfhN8HCefWDiGhY05HVKLzhSXnT NGs1U3jT3cU5bBAnd7HQyaBR5Gc0JqyNDxxFxoLdbZJut+AfsJIXMzINcNDIeCggCyV+vsUN3e1 zD84dWP+ckKPvzOGTjXG8F4gj0cRY+HEVGkoGNS6dGASzY5L3kjmSqo3UBLG7ug== X-Received: by 2002:a05:600c:5106:b0:426:67e0:3aa with SMTP id 5b1f17b1804b1-426707cee07mr14014605e9.1.1720521976681; Tue, 09 Jul 2024 03:46:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/9nlMV2fi1h21gnXCNPSJp3w9/hO3aQH5rA9bDONuM5D9HIwipNJQ27peTGfgsB2mxMRrxA== X-Received: by 2002:a05:600c:5106:b0:426:67e0:3aa with SMTP id 5b1f17b1804b1-426707cee07mr14014495e9.1.1720521976318; Tue, 09 Jul 2024 03:46:16 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3344:1710:e810:1180:8096:5705:abe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427270238a6sm2315325e9.20.2024.07.09.03.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 03:46:15 -0700 (PDT) Message-ID: Subject: Re: [PATCH] selftests/net: missing close function in randomize function From: Paolo Abeni To: Liu Jing , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, shuah@kernel.org Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 09 Jul 2024 12:46:14 +0200 In-Reply-To: <20240705082421.7061-1-liujing@cmss.chinamobile.com> References: <20240705082421.7061-1-liujing@cmss.chinamobile.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-07-05 at 16:24 +0800, Liu Jing wrote: > in randomize function, there is a open function, but there is no > close function in the randomize, which is easy to cause memory leaks. Please not that the file descriptor is not leaked, the kernel will dispose it at process exit() time. >=20 > Signed-off-by: Liu Jing > --- > tools/testing/selftests/net/tcp_mmap.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selft= ests/net/tcp_mmap.c > index 4fcce5150850..ab305e262d0a 100644 > --- a/tools/testing/selftests/net/tcp_mmap.c > +++ b/tools/testing/selftests/net/tcp_mmap.c > @@ -438,6 +438,7 @@ static void randomize(void *target, size_t count) > perror("read /dev/urandom"); > exit(1); > } > + close(urandom); > } > =20 > int main(int argc, char *argv[]) This is outside any loop, so the overall effect WRT the self-test itself is not visible. I think we are better off without this kind of changes, unless they are part of a largish re-factor. Thanks, Paolo