From: Qingfang Deng <qingfang.deng@linux.dev>
To: Eric Dumazet <edumazet@kernel.org>
Cc: netdev-bot+sinfo@kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Breno Leitao <leitao@debian.org>, Kees Cook <kees@kernel.org>,
Taegu Ha <hataegu0826@gmail.com>,
Tom Parkin <tparkin@katalix.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
James Chapman <jchapman@katalix.com>,
Sashiko <sashiko-bot@kernel.org>, Felix Fietkau <nbd@nbd.name>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH net] ppp: linearize bridged packets when required
Date: Thu, 22 Oct 2026 10:18:12 +0800 [thread overview]
Message-ID: <b3091ab0-0e1b-4835-ae36-14978af46fa3@linux.dev> (raw)
In-Reply-To: <CAL4Wiip2F59XO3BrjUHVrFqYMuD-LxNmZXhtftkV-JG0Ya84Yg@mail.gmail.com>
On 2026/10/22 1:55, Eric Dumazet wrote:
>> What about NETIF_F_FRAGLIST?
> I do not see your point. Can you elaborate?
>
> There’s also nothing left to gain on fraglist packets.
>
> SKB_GSO_FRAGLIST packets already go through skb_segment_list(),
> which just unchains the original skbs without copying, as the fraglist
> test run showed.
>
> Frag_list skbs that aren’t fraglist GRO go through skb_segment(),
> which with NETIF_F_SG already shares the pages of the chained skbs
> instead of copying them.
I've run selftests and confirmed that NETIF_F_FRAGLIST is unnecessary here.
One extra finding: passing NETIF_F_SG conditionally can avoid an extra
reallocation in skb_linearize().
segs = skb_gso_segment(skb, chan->direct_xmit ? NETIF_F_SG : 0);
prev parent reply other threads:[~2026-10-22 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 2:36 Qingfang Deng
2026-10-21 2:39 ` netdev-bot+sinfo
2026-10-21 3:07 ` Qingfang Deng
2026-10-21 9:24 ` Eric Dumazet
2026-10-21 10:27 ` Qingfang Deng
2026-10-21 16:31 ` Eric Dumazet
2026-10-21 17:03 ` Qingfang Deng
2026-10-21 17:55 ` Eric Dumazet
2026-10-22 2:18 ` Qingfang Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3091ab0-0e1b-4835-ae36-14978af46fa3@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hataegu0826@gmail.com \
--cc=jchapman@katalix.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=sashiko-bot@kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®