From: Krzysztof Kozlowski <krzk@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andreas Kemnade <andreas@kemnade.info>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 02/15] dt-bindings: Add trickle-charge upper limit
Date: Wed, 29 Oct 2025 07:17:20 +0100 [thread overview]
Message-ID: <b30eed8e-c8f8-4077-9e6a-0217c5827981@kernel.org> (raw)
In-Reply-To: <20251029-adamant-mamba-of-patience-cddb65@kuoka>
On 29/10/2025 07:03, Krzysztof Kozlowski wrote:
> On Mon, Oct 27, 2025 at 01:45:05PM +0200, Matti Vaittinen wrote:
>> Some of the chargers for lithium-ion batteries use a trickle-charging as
>> a first charging phase for very empty batteries, to "wake-up" the battery.
>
> In the few cases I was dealing with charging circuits, trickle charging
> was used in context of top-off charging, so when battery is 100%. It's
> also documented at Wiki like that:
> https://en.wikipedia.org/wiki/Trickle_charging
>
>> Trickle-charging is a low current, constant current phase. After the
>> voltage of the very empty battery has reached an upper limit for
>> trickle charging, the pre-charge phase is started with a higher current.
>>
>> Allow defining the upper limit for trickle charging voltage, after which
>> the charging should be changed to the pre-charging.
>
> pre-charging is the trickle charging, no? Or you want to say that
> trickle-charging is pre-pre-charging? But then what is pre-charging in
> this binding?
Now I see that you added initial trickle-charging in commit
e3420b49949c79d6182dd8128fa7a3958da01b07. I looked at TI chargers for
LiIon/LiPo batteries and few popular models use the same meaning/cycles
as you here. Probably in LiIon/LiPo you cannot or should not use trickle
for top-off charging (CV phase).
For NiMh these TI chargers use term "Trickle Maintenance Charge" (e.g.
bq24400), so in separate or this patch please also clarify the
description of properties that this is trickle-charging for LiIon/LiPo
batteries, so the pre-pre charging.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-29 6:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 11:44 [PATCH v2 00/15] Support ROHM BD72720 PMIC Matti Vaittinen
2025-10-27 11:44 ` [PATCH v2 01/15] dt-bindings: regulator: ROHM BD72720 Matti Vaittinen
2025-10-27 21:03 ` Rob Herring
2025-10-27 11:45 ` [PATCH v2 02/15] dt-bindings: Add trickle-charge upper limit Matti Vaittinen
2025-10-29 6:03 ` Krzysztof Kozlowski
2025-10-29 6:17 ` Krzysztof Kozlowski [this message]
2025-10-29 6:24 ` Matti Vaittinen
2025-10-29 6:22 ` Matti Vaittinen
2025-10-29 6:32 ` Matti Vaittinen
2025-10-29 13:26 ` Linus Walleij
2025-10-29 13:33 ` Krzysztof Kozlowski
2025-10-27 11:45 ` [PATCH v2 03/15] dt-bindings: power: supply: BD72720 managed battery Matti Vaittinen
2025-10-27 21:08 ` Rob Herring
2025-10-27 22:34 ` Linus Walleij
2025-10-27 11:45 ` [PATCH v2 04/15] dt-bindings: mfd: ROHM BD72720 Matti Vaittinen
2025-10-27 21:13 ` Rob Herring
2025-10-29 12:22 ` Matti Vaittinen
2025-10-27 21:20 ` Andreas Kemnade
2025-10-29 12:23 ` Matti Vaittinen
2025-10-27 22:42 ` Linus Walleij
2025-10-29 12:30 ` Matti Vaittinen
2025-10-29 13:08 ` Linus Walleij
2025-10-27 11:46 ` [PATCH v2 05/15] dt-bindings: leds: bd72720: Add BD72720 Matti Vaittinen
2025-10-28 8:25 ` Krzysztof Kozlowski
2025-10-27 11:46 ` [PATCH v2 06/15] mfd: rohm-bd71828: Use regmap_reg_range() Matti Vaittinen
2025-10-27 11:46 ` [PATCH v2 08/15] regulator: bd71828: rename IC specific entities Matti Vaittinen
2025-10-27 12:14 ` Mark Brown
2025-10-27 11:47 ` [PATCH v2 09/15] regulator: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-10-27 12:15 ` Mark Brown
2025-10-27 11:47 ` [PATCH v2 10/15] gpio: Support ROHM BD72720 gpios Matti Vaittinen
2025-10-27 11:47 ` [PATCH v2 11/15] clk: clk-bd718x7: Support BD72720 clk gate Matti Vaittinen
2025-10-27 11:47 ` [PATCH v2 12/15] rtc: bd70528: Support BD72720 rtc Matti Vaittinen
2025-10-27 12:38 ` Alexandre Belloni
2025-10-27 13:02 ` Matti Vaittinen
2025-10-27 11:48 ` [PATCH v2 13/15] power: supply: bd71828: Support wider register addresses Matti Vaittinen
2025-10-27 11:48 ` [PATCH v2 14/15] power: supply: bd71828-power: Support ROHM BD72720 Matti Vaittinen
2025-10-27 11:48 ` [PATCH v2 15/15] MAINTAINERS: Add ROHM BD72720 PMIC Matti Vaittinen
2025-10-28 6:06 ` [PATCH v2 07/15] mfd: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-10-28 6:39 ` [PATCH v2 00/15] Support ROHM BD72720 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b30eed8e-c8f8-4077-9e6a-0217c5827981@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andreas@kemnade.info \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®