From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750977AbdE3TDO (ORCPT ); Tue, 30 May 2017 15:03:14 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34538 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbdE3TDM (ORCPT ); Tue, 30 May 2017 15:03:12 -0400 Subject: Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170530183319.10718-1-vivien.didelot@savoirfairelinux.com> <20170530183319.10718-5-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Tue, 30 May 2017 12:03:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170530183319.10718-5-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Vivien, On 05/30/2017 11:33 AM, Vivien Didelot wrote: > The struct dsa_device_ops defines the rcv function with 2 unused > arguments struct packet_type *pt, and struct net_device *orig_dev. > > This patch removes them from the definition and implementations. > > Reviewed-by: Andrew Lunn > Signed-off-by: Vivien Didelot I actually have a patch pending that adds support for HW insertion/extraction of switch tags (broadcom HW supports that) which require the orig_dev to be there so we know what features are supported by the master network device. Do you mind dropping this one from your patch series? Thanks! -- Florian