From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF414C77B7A for ; Fri, 2 Jun 2023 06:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234014AbjFBGqS (ORCPT ); Fri, 2 Jun 2023 02:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234022AbjFBGqL (ORCPT ); Fri, 2 Jun 2023 02:46:11 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FAFC1B9 for ; Thu, 1 Jun 2023 23:46:08 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-969f90d71d4so240865566b.3 for ; Thu, 01 Jun 2023 23:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685688367; x=1688280367; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sn5GKIPUq7n4vlCzPHxBlLVhBwHsIY9pwft/0PIKGBs=; b=uRHXQmKFfg6Ty6YPEOvbVuHCYKuBOonqM93J4SRlD1cgcAk1u+uNI+jfV5y01WPD+r 8yp0tqQonwy0Of/F4l5ueo7PDlxpGUCHWL0/cvwRF9wLedTFpqa+M1uXDs/VPvCKHsQz uqNjb3u0y7i6egKZVxVMPPyfFjXY6Td+g06Owx9alBj+o5Lh8x1WQrd6zAShZ/Fq+tKP u6k4idSxXuz9rZvNmguP7cTNwcgnYzn7himsVHIEwZvfUjSgNmWj7oWPkusc4SCli2cw i0zMjtJx5laVjN6jCaQTdd/+VC1uBSWtJyoHDYTstRMSxDQEWCMgde7jHF+TyBlZyBcO K3Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685688367; x=1688280367; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sn5GKIPUq7n4vlCzPHxBlLVhBwHsIY9pwft/0PIKGBs=; b=PNGrGLhdUiZFj6zECIiKmDVRP+WE3jMfhD9nxqjVdhvX2I/H4PkSMvK4FirFayi0pN q/mlx2e7lxdcHUrpsIETk4pInnVMJdJL3ZIfyn5gDml2xduy9i1IO70wB/6+HxprGIbq 9abuOiz6Jg9axgIgt5sYhbdqSm8r3GsD4EG1ikvAjobt5Pk3SV6uhn5Wp1SIJaHDsltn pf2ANsMoqA4Mv5Wn7XdpGriowTqZN4KpYIM5I/3Mbrvi68WpfxWOihoU8KXoRkJ4jkiu vBMvzCir+v9KVQhaNBgujASXQbfIv7mCb0tyLtxtOgXfxZ7Aa+PbUh5xpr4DbUX5btLJ 4ScQ== X-Gm-Message-State: AC+VfDwV0qn14zWK09oqwLqC9voVisPCiCCUXOwLGsaJs9MLGyb3wv1E 8v+yNS3TYgMsKNtpYYMM4IHE/g== X-Google-Smtp-Source: ACHHUZ7Q1uVjMhamKfseFwmnkiS2/n+5edox82SflnDS21Cz4GqWA+5aSrTkhy1Md9Sa95VNrecatA== X-Received: by 2002:a17:907:746:b0:973:d2d1:e7 with SMTP id xc6-20020a170907074600b00973d2d100e7mr7718987ejb.71.1685688366895; Thu, 01 Jun 2023 23:46:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id bq24-20020a170906d0d800b0097436a54b4bsm393664ejb.0.2023.06.01.23.46.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 23:46:06 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 08:46:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] dt-bindings: pinctrl: Drop k3 Content-Language: en-US To: Nishanth Menon , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Linus Walleij Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra , Tero Kristo References: <20230601173831.982429-1-nm@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20230601173831.982429-1-nm@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2023 19:38, Nishanth Menon wrote: > For convenience (less code duplication), the pin controller pin > configuration register values were defined in the bindings header. > These are not some IDs or other abstraction layer but raw numbers used > in the registers. > > These constants do not fit the purpose of bindings. They do not > provide any abstraction, any hardware and driver independent ID. In > fact, the Linux pinctrl-single driver actually do not use the bindings > header at all. > > Commit f2de003e1426 ("dt-bindings: pinctrl: k3: Deprecate header with > register constants") already moved users to the local header, so, drop > the binding header. See background discussion in [1]. > This happened just a release ago, so I would rather expect to have it deprecated for some time, so out of tree DTBs won't be broken. But any platform ABI is up to platform maintainer so: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof