mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
	iommu@lists.linux-foundation.org
Cc: "Jörg Rödel" <joro@8bytes.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: iommu: Improve exception handling in iommu_group_alloc()
Date: Tue, 2 Jun 2020 07:01:02 +0200	[thread overview]
Message-ID: <b31fbcd1-b5f8-992b-a994-2a950ab36b61@web.de> (raw)
In-Reply-To: <20200602015044.GA89266@VM20190228-100.tbsite.net>

>> * I suggest to avoid the specification of duplicate function calls.
>>   Will it be helpful to add a few jump targets?
>>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455
>
> I don't think it is helpful or readable to add some jump targets here,
> since the exception handling is very simple here.

Do you disagree to the application of the Linux coding style then
for the recommended exception handling?

Regards,
Markus

  reply	other threads:[~2020-06-02  5:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 12:38 [PATCH] " Markus Elfring
2020-06-02  1:50 ` Baolin Wang
2020-06-02  5:01   ` Markus Elfring [this message]
2020-06-02  5:56     ` Baolin Wang
2020-06-02  7:06       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b31fbcd1-b5f8-992b-a994-2a950ab36b61@web.de \
    --to=markus.elfring@web.de \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®