From: David Heidelberg <david@ixit.cz>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles
Date: Thu, 17 Sep 2026 12:25:36 +0200 [thread overview]
Message-ID: <b324f0b8-0875-457f-936c-89b858d082fa@ixit.cz> (raw)
In-Reply-To: <20260917-heavenly-weasel-of-criticism-1add6b@quoll>
On 17/09/2026 12:21, Krzysztof Kozlowski wrote:
> On Tue, Sep 15, 2026 at 04:32:24PM +0200, David Heidelberg wrote:
>> + - description: Xiaomi Mi 8 family
>> + items:
>> + - enum:
>> + - xiaomi,dipper
>> + - xiaomi,equuleus
>> + - xiaomi,ursa
>> + - const: xiaomi,dipper-common
>
> We do not make "common" compatibles.
> git grep common -- Documentation/devicetree/bindings/arm/qcom.yaml
TBH I have mental issue with calling it xiaomi,dipper-dipper
All three devices are branded as own devices, just based on 99.9% same base.
I'm not aware of any internal name which group these devices.
I could call it like xiaomi,common, but there is the polaris and beryllium,
which aren't "that common" with these three.
Do you have idea what to do in this situation?
David
>
> See other examples how this can be named, even one below:
>
>> + - const: qcom,sdm845
>> +
>> - description: Xiaomi Poco F1
>> items:
>> - enum:
>> - xiaomi,beryllium-ebbg
>> - xiaomi,beryllium-tianma
>> - const: xiaomi,beryllium
>> - const: qcom,sdm845
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-09-17 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:32 [PATCH v2 0/2] Introduce support for Xiaomi Mi 8 David Heidelberg via B4 Relay
2026-09-15 14:32 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles David Heidelberg via B4 Relay
2026-09-17 10:21 ` Krzysztof Kozlowski
2026-09-17 10:25 ` David Heidelberg [this message]
2026-09-18 8:40 ` Krzysztof Kozlowski
2026-09-15 14:32 ` [PATCH v2 2/2] arm64: dts: qcom: add Xiaomi Mi 8 (dipper) David Heidelberg via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b324f0b8-0875-457f-936c-89b858d082fa@ixit.cz \
--to=david@ixit.cz \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®