From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753796AbdJIBaP (ORCPT ); Sun, 8 Oct 2017 21:30:15 -0400 Received: from m12-13.163.com ([220.181.12.13]:39054 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753408AbdJIBaO (ORCPT ); Sun, 8 Oct 2017 21:30:14 -0400 From: Jia-Ju Bai To: gregkh@linuxfoundation.org, m@bues.ch, sudipm.mukherjee@gmail.com, akpm@linux-foundation.org, johannes@sipsolutions.net, dahinds@users.sourceforge.net Cc: linux-pcmcia@lists.infradead.org, Linux Kernel Mailing List , linux-wireless@vger.kernel.org Subject: [BUG] ssb: Possible sleep-in-atomic bugs in ssb_pcmcia_read8 Message-ID: Date: Mon, 9 Oct 2017 09:29:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: DcCowABXa0zw0NpZgwGzMQ--.36775S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF48XF4DtF4kCFyruFWrAFb_yoW3CFb_ur 1Fvr17Jr4UXwsFkwnrZr4rZrWSqayDurn8AFs5WF15ZrsFqF9rC3ZFyFnxWw1xZ3Z8J3Z5 WrW7Xr15ur1avjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYjg4DUUUUU== X-Originating-IP: [166.111.70.12] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiYwVselaDvJnUmAABsN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to pcmcia.c, the driver may sleep under a spinlock. The function call paths are: ssb_pcmcia_read8 (acquire the spinlock) select_core_and_segment ssb_pcmcia_switch_segment ssb_pcmcia_cfg_write pcmcia_write_config_byte pcmcia_access_config (drivers/pcmcia/pcmcia_resource.c) mutex_lock --> may sleep ssb_pcmcia_read8 (acquire the spinlock) select_core_and_segment ssb_pcmcia_switch_segment sssb_pcmcia_cfg_read pcmcia_read_config_byte pcmcia_access_config (drivers/pcmcia/pcmcia_resource.c) mutex_lock --> may sleep A possible fix is to use spinlock instead of mutex lock in pcmcia_access_config in drivers/pcmcia/pcmcia_resource.c. These bugs are found by my static analysis tool and my code review. Thanks, Jia-Ju Bai