From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47281AF0D8 for ; Fri, 20 Dec 2024 08:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734684710; cv=none; b=cxHIgf/pfAX5mZ3ydNPlqMqeCKoYe90Cq2CK5wiuiDTv6j+1DAwWW8J+5rALL3LNHh24i0aEnNG8FEqLkSuSnmQmocgYoABzwweIHl3CDJEkE5zPLQO2ZiMhnfj+Vck8zIpKpEo5og9cYyfjPkRNQ8f6HHjaYYNyN8ES3OQEKVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734684710; c=relaxed/simple; bh=dLvlvrSDVECLfSSOZLPtBio7oxSxaD/euh821NhhzH0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oPPOnxZhcWCFt8p3iIbdJu+NvF/F2or9aaUdbriepx9xthlH2rJZLWsmeGuYefWmd7R9OSALQtqyW+2ErjKUFoqe+G7gE5dukonqxC/8goJiPSWerA0/np2qOUX38H199mwncgVHoV1BYYdsAV7W7Du6WabkZ5wtjaW1NuVIARs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=YOgGBYj+; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="YOgGBYj+" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-53ff1f7caaeso1668897e87.0 for ; Fri, 20 Dec 2024 00:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1734684707; x=1735289507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HlP9TSmbf2+mm+BDSbQWH0BPbAWuSsitnZyKaFurly8=; b=YOgGBYj+VhQ3doJVNpZboMnj0+JKvbXVO/UPYP06dqULx8U1j2F7chAZuZlZMf0GAH xBzkkNmghnfzfqfkMMo1c4nudBJqtZYunJRm+vOSlDh/MtgRnmOkbh3Er71uLGAzoxai bp18zIcCKjIPlGuVJKDH7rSRXKg7KOGDSaknrZNHb/8bmrmN+4jTBY2GcGAPZ49W5qKc Bdy3eE4GhWiwehqq6Z54VvqhjYA2vPcMuiBrdJKUJXP9XQ1exayVRfHGHZ1yI7EZNlqE GpYop2BzY4t4qvgBrLZRGh4HPh/VwpUSgl4U/ZAahyDi0/tiVLEMQ2dPK8ksHN5k41Do 8dQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734684707; x=1735289507; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HlP9TSmbf2+mm+BDSbQWH0BPbAWuSsitnZyKaFurly8=; b=vdOFmtkLAAGTgxqThBWchDts42LbJs5qTV7DAYR25P8NeJ0Hx3J/CgI7d3UJ1dLl2E 5Ew9hg3POlfdFPsNd41BFpJgAtQbo22/SGSxFZCAvMSTBAo6b/FfKY8I8Y3ADpLWektd RYEmTEAxGsfUUT39wadUmakXs44J7iO9likPq9TaS0fsPN7+WvdYbAQilIEFC9UN6NWh bo+pHf/2enUTktOwxtFhJiBBb2S9+DrVSoC9vmkobx3IhAISTUACmc1xiSS+1Sx29LM8 kRHJc6UO/957CU01r+iLyZbwqx4nAvY1fwlfHe8dwSHopIEJ/wXWKDhtogbYw8i/UrCM MBMQ== X-Forwarded-Encrypted: i=1; AJvYcCW46EXiQVWeZEMwj3jH3TtC7tl1xdAtzQauKx2pOFuXG/Pw7kF7R/cdpQzz2NhAkEjl0J4/LmLRxweLPW4=@vger.kernel.org X-Gm-Message-State: AOJu0YzKubIq/mdrnXZEz9FkBvE9TS7k4EkVGa6bDdPuyRW9WqsXossh M/S6upqAGttC+ptpkO4BMAd7ZRsCqC5Pa3BbZJrPHsuZpMQIZo+90Uq6DyJRchU= X-Gm-Gg: ASbGncuxpjpkWh+HH6YOj+lsepMrk+2K3hcyKpFDU1PPE7UaQk2GamfSfTGNPP37YJb aQZR3wnnThbos/x6n82IYUmANu/GlG49MykoYzLZYLgf4G6qXiGvIZfMM4nW9kfBhZvJ5pK5nos onW2EOXzlC0XP4uZ7Ag2cZmJGYxkKgBxcwqlPd2BmvA0BEmGWV0eTu7XPLBhsTA2n5i7wMOLT6K /xjIXcX2umV9i+t8v36xm+qN7nhIMwXyt7D+m2AFPGkibevsgPLl9aQ0wm1iwKfZTf2vp6Flm3M X-Google-Smtp-Source: AGHT+IFWZfCVQxkIx3QiVtrU+By8AKq3j5SPak95YvS6Y5V5U72ZXcudCvty8vOxCPaa6vwS7SEBxg== X-Received: by 2002:a05:6512:3e2a:b0:540:2311:28c5 with SMTP id 2adb3069b0e04-5422956c4c7mr506746e87.57.1734684706832; Fri, 20 Dec 2024 00:51:46 -0800 (PST) Received: from [192.168.0.104] ([91.198.101.25]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54223813806sm421610e87.114.2024.12.20.00.51.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 00:51:46 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 13:51:44 +0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/2] net: renesas: rswitch: request ts interrupt at port open To: Michal Swiatkowski Cc: Yoshihiro Shimoda , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Dege , Christian Mardmoeller , Dennis Ostermann References: <20241220041659.2985492-1-nikita.yoush@cogentembedded.com> <20241220041659.2985492-3-nikita.yoush@cogentembedded.com> Content-Language: en-US, ru-RU From: Nikita Yushchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Wasn't previous implementation more obvious? This ts irq you have one > per device, no per port, so it better fit to one time initialization > instead of checking if it is first and last port. > > Anyway, it is your descision, patch looks correct: > Reviewed-by: Michal Swiatkowski For data interrupts, after making them per-port, it is better to request only for opened device, to avoid unneeded calls to shared handlers when some ports are up and some are not. And once data interrupts are requested at open, it looks cleaner for me to request ts interrupt at open as well. Although I agree that this is matter of taste. Nikita