From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751247AbdFDMxK (ORCPT <rfc822;w@1wt.eu>);
        Sun, 4 Jun 2017 08:53:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34174 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751139AbdFDMxD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 4 Jun 2017 08:53:03 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7F1034E4D4
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7F1034E4D4
Subject: Re: [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bin Gao <bin.gao@intel.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>
References: <20170523212434.12981-1-hdegoede@redhat.com>
 <20170530090214.s2f4ivj7ahiabhml@dell>
 <CAHp75Vcg2AmHnyPSx3b1Na1w2XBAT7CLkrWAHA5jEBVa5foCuw@mail.gmail.com>
 <20170530122003.scaw5f7diez7uhl6@dell>
 <1496149552.28981.24.camel@linux.intel.com>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <b33357a8-03f5-3d13-6c21-06ff55a91fbe@redhat.com>
Date: Sun, 4 Jun 2017 14:52:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <1496149552.28981.24.camel@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 04 Jun 2017 12:53:03 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 30-05-17 15:05, Andy Shevchenko wrote:
> On Tue, 2017-05-30 at 13:20 +0100, Lee Jones wrote:
>> On Tue, 30 May 2017, Andy Shevchenko wrote:
>>
>>> On Tue, May 30, 2017 at 12:02 PM, Lee Jones <lee.jones@linaro.org>
>>> wrote:
>>>> On Tue, 23 May 2017, Hans de Goede wrote:
>>>>> +static const struct i2c_device_id cht_wc_i2c_id[] = {
>>>>> +     { }
>>>>> +};
>>>>
>>>> What's the point in this empty table?
>>>
>>> This is artifact of I2C framework, otherwise if will be not
>>> enumerated.
>>>
>>> +Wolfram.
>>>
>>> Wolfram, can we fix this? (In case we have either ACPI table or OF
>>> table there is no need to oblige providing empty legacy table)
>>
>> I think I fixed this already.
>>
>> Hint: `git grep probe_new -- drivers/i2c` >
> Indeed.
> Thanks for a hint!

Unfortunately switching to probe_new (which I've done for
the upcoming v9 of the MFD CHT Whiskey Cove driver) is not enough,
as i2c_device_probe() (from drivers/i2c/i2c-core) still has:

         /*
          * An I2C ID table is not mandatory, if and only if, a suitable Device
          * Tree match table entry is supplied for the probing device.
          */
         if (!driver->id_table &&
             !i2c_of_match_device(dev->driver->of_match_table, client))
                 return -ENODEV;

So before we can remove the empty id tables from various ACPI
drivers we first need to extend this check to also work with
ACPI device matching.

Regards,

Hans