From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Sayyad Abid <sayyad.abid16@gmail.com>, linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] staging: rtl8723bs: fix position of opening braces
Date: Sun, 8 Sep 2024 22:33:39 +0200 [thread overview]
Message-ID: <b335b3dc-61b4-4e39-8627-76bd4acc82c2@gmail.com> (raw)
In-Reply-To: <20240908101110.1028931-3-sayyad.abid16@gmail.com>
On 9/8/24 12:11, Sayyad Abid wrote:
> This patch fixes the coding style issue of opening bracket "{" being on
> the next line.
>
> Signed-off-by: Sayyad Abid <sayyad.abid16@gmail.com>
>
> ---
> drivers/staging/rtl8723bs/include/rtw_security.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
> index 487d69460cec..3ccbccf92417 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> @@ -170,8 +170,7 @@ struct security_priv {
>
> #define GET_ENCRY_ALGO(psecuritypriv, psta, encry_algo, bmcst)\
> do {\
> - switch (psecuritypriv->dot11AuthAlgrthm)\
> - {\
> + switch (psecuritypriv->dot11AuthAlgrthm) {\
> case dot11AuthAlgrthm_Open:\
> case dot11AuthAlgrthm_Shared:\
> case dot11AuthAlgrthm_Auto:\
> @@ -191,8 +190,7 @@ do {\
>
> #define SET_ICE_IV_LEN(iv_len, icv_len, encrypt)\
> do {\
> - switch (encrypt)\
> - {\
> + switch (encrypt) {\
> case _WEP40_:\
> case _WEP104_:\
> iv_len = 4;\
Hi Sayyad,
I cannot apply this patch. Please rebase.
Thanks for your support.
Bye Philipp
next prev parent reply other threads:[~2024-09-08 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 10:11 [PATCH 0/6] staging: rtl8723bs: Fix various coding style issues Sayyad Abid
2024-09-08 10:11 ` [PATCH 1/6] staging: rtl8723bs: fix use of tab wherever possible Sayyad Abid
2024-09-08 20:23 ` Philipp Hortmann
2024-09-09 7:57 ` Sayyad Abid
2024-09-08 10:11 ` [PATCH 2/6] staging: rtl8723bs: fix position of opening braces Sayyad Abid
2024-09-08 20:33 ` Philipp Hortmann [this message]
2024-09-09 7:59 ` Sayyad Abid
2024-09-08 10:11 ` [PATCH 3/6] staging: rtl8723bs: fix space before tabs Sayyad Abid
2024-09-08 10:11 ` [PATCH 4/6] staging: rtl8723bs: fix comment with a trailing */ on a separate line Sayyad Abid
2024-09-08 20:26 ` Philipp Hortmann
2024-09-09 7:58 ` Sayyad Abid
2024-09-08 10:11 ` [PATCH 5/6] staging: rtl8723bs: fix switch and case to be at same indent Sayyad Abid
2024-09-08 10:11 ` [PATCH 6/6] staging: rtl8723bs: fix no space before tab and statement start on tabstop Sayyad Abid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b335b3dc-61b4-4e39-8627-76bd4acc82c2@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sayyad.abid16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome