From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 603F53AB47A for ; Tue, 18 Aug 2026 13:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787058235; cv=none; b=HSVj3QGoY1zyS32a/D7fNUNTlpl4ma9DxGCzAS4i9VnCrIs6pc56l+q1C4vMgZtICsoiV3uVKzkGTPD6Y+cTZuWbk+FHTp8Sr0pkXCO2rZaPViGPG1q9G9Xx4kIlTPjjfbVZrzdwx6fhGWWEzF57NhPPRfgkpFvY4Gv8v7r5ZCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787058235; c=relaxed/simple; bh=6CtZYMYT4XpUFtb1WYTDbjv8lDt8QsA8X9rTqudbuL4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ACghqwOKZ43z2RnsO5G7UxObApKvoq9RlGhZPhDn6WN2YmCRiot0HPcme/zZKs1FAZpalRgc7lTqKMSblo+bkjH+wCvl1wkE1qCF/o6A85gIguU/K20neJqu1fERw91ZqmplqpFLgFd6DbJQ6ePsJyPuDpZf6m6wjoFeMhQK9uQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RqNoT8VP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ohv1np9n; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RqNoT8VP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ohv1np9n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787058230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+uKpz7vxdNODpZByPKeGLjosat28K4nUQ0xLNtgYDM=; b=RqNoT8VPgxb88P/YAIzeSzoX1HLt8Urry8ikA4ec/plODIuFHi5kK23MsxwXYNvkCwDl0N wTww3siKjcCv++82bVoeADwyKRlQjnIfzDcRRAB5yxIOAMD4iUISRS+ahPRjQ0129vaKjG Kmy2Br5ZEjXusFDbfd1ZHIsAls9Q1c4= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-mUg8N-XaNrSWu0_9OBmlwA-1; Tue, 18 Aug 2026 09:03:46 -0400 X-MC-Unique: mUg8N-XaNrSWu0_9OBmlwA-1 X-Mimecast-MFC-AGG-ID: mUg8N-XaNrSWu0_9OBmlwA_1787058225 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-c2192261d79so73759566b.3 for ; Tue, 18 Aug 2026 06:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787058225; x=1787663025; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=I+uKpz7vxdNODpZByPKeGLjosat28K4nUQ0xLNtgYDM=; b=Ohv1np9nDTeiGArPJ/V1CQbOkmziALY26iWRG/3qctOJV3pwMyFHmvoAoAGQ1tfp8a MSHIhM7Jii0Fh27t2NH9jV99y40pPNrOAjuKNuGWHBFJXmZK2wmMEMLoXOIvPGaxVKNm IFTwlte5M9xOlWAN5k/XVu8cZTvAkGW4Z7LtpBIyivEbyvHkN1UdKsMy/YKItQwVyqWt Ff8xBtM9xiMq6j2MedGa8Bd+ppVqbPnuXeb1XzbZ3ub3/OOqBQYxV4OHUlKroZYBmkj4 9d+g+745h532XPjXKOYowGuN9qo5UTO7WiCqYMZhIuhno1XX+zkYuNB57JBwK1bTZGBN CHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787058225; x=1787663025; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I+uKpz7vxdNODpZByPKeGLjosat28K4nUQ0xLNtgYDM=; b=RQs2h4ElncDIQuGPIzLLTCcpAA7GWlmoJjkKXkt1e0SE9+5M69zFHCeWfFohZ5SLe7 /ugcGBNC9x6t6aiSlZ47s55vPDRkNZxI9YiTmpm8ZltzgekvK6/VENWdExC3TWuX/VTL SpyLgJ+qMTkL/RHjwiIe85orK/zOH43vdQdjvUb/hn0QKTAhc5nQzxi4QguOcWiX5msK YBF6tpAbSPHW4dVmfI6MrFybxthbpM2voELujqY/4u/WaI34tHgyjNEHyBHtP89aPxd7 Yh8YrBKmPCi7VwzayDLVWh2+xn7T9D0SlSdGnniQwDrLS4sutwXaIUhYOARqNf/5PVEi Dw/w== X-Forwarded-Encrypted: i=1; AHgh+RprfeavJ5eAA0Rq9tFXzpOs1Fd6JG16ZRtyPuhOcTy5HOCkSEztHCwfBCJyLvPzqDBaXc6u3Lo03P8WgOY=@vger.kernel.org X-Gm-Message-State: AOJu0YyBWLHJT2h8jZPXEIs5wP9Phxy2Ix+qZSLMewyO/KDDBcubCtPM fgEiBWiXDcvgolH9NYaTg76CTOD0dHxOvaJA5x/+j+ssmj3lhP9TIBxUQ7HOGC66TcO9wefzpQ5 Fyn1WVqjbTowsK5gTkWM9SEkE9ZRNdr/Nqzqtbb/Q6zMlRgc4eUDDk6fSvUS7sFCIJ3/rWfkRRg == X-Gm-Gg: AR+sD13uZLVS0EHCuQR/1eS36SrZ12y/IrBDLhsRHNpnXbABq0jlWryxhOn+UMAc7Vu DpqmoK+4+vTMhCsddhw4Bm9MxPR1qYXtk/01k1zVc7Gw9KaTAwS03YDdcievlrwHDYgyYriNkv9 z7tQfrTigS80s8dhKFxPVUf5F2NPsLxUPrLDBNRVb6d/JUsPd7jYp6qnIASU5TRmw4SL2PaHu0R QpcAATIQAvZSzgZIWnO8bJ5mhlTAyOCb4Mhny37feYNYi1penZBsiGBLiCpWbrZERnXPWfaQDuy yRtmlqcW4EjGjxthOn4HY2pD67+puJHy0hJdXIAFq9ls5diGJCkshBcPIBiZRNvu8ie3/VjeO0L KJPoDue6YTarNpKFwvzqwY/JPvlsm4HIneQBXxOIvIkyh2h+tPTgn5rNvbX8z5FgHKGFNvIETuG A= X-Received: by 2002:a05:6402:913:b0:6a1:44c8:edc4 with SMTP id 4fb4d7f45d1cf-6a38a95be16mr16679750a12.12.1787058224927; Tue, 18 Aug 2026 06:03:44 -0700 (PDT) X-Received: by 2002:a05:6402:913:b0:6a1:44c8:edc4 with SMTP id 4fb4d7f45d1cf-6a38a95be16mr16679659a12.12.1787058224457; Tue, 18 Aug 2026 06:03:44 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d8596ce4sm1724287a12.21.2026.08.18.06.03.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 06:03:43 -0700 (PDT) Message-ID: Date: Tue, 18 Aug 2026 15:03:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v14 0/4] net: pse-pd: add Realtek PSE MCU support To: Jonas Jelonek , Oleksij Rempel , Kory Maincent , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Golle , =?UTF-8?Q?Bj=C3=B8rn_Mork?= , Sander Vanheule References: <20260813222036.873930-1-jelonek.jonas@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260813222036.873930-1-jelonek.jonas@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/14/26 12:20 AM, Jonas Jelonek wrote: > This series adds a PSE-PD driver for the microcontroller (MCU) that > fronts the PSE silicon on a range of managed switches, together with its > DT binding. > > Hardware model > ============== > > These boards do not expose the PSE chips to the host directly. A small > microcontroller sits on an I2C/SMBus or UART bus and manages one or more > PSE chips behind it; the host CPU only ever talks to that MCU, using a > fixed 12-byte request/response protocol with a trailing checksum. The > PSE silicon never appears on the bus. > > Two generations of the protocol exist, both Realtek's: an older one on > boards with Broadcom PSE silicon (BCM59111, BCM59121) and a newer one > used with Realtek's own PSE silicon (RTL8238B, RTL8239, RTL8239C). They > diverge in opcode numbering and a few response layouts; the driver > abstracts that behind a per-dialect opcode table and parser hooks, > selected by the compatible. The specific PSE chip behind the MCU is > detected at runtime and only influences per-chip constants (power scaling > and the per-port cap). > > The compatibles > =============== > > The protocol compatibles name two generations of the Realtek protocol, > with the I2C framing folded in: > > realtek,pse-mcu-gen1 gen1, UART > realtek,pse-mcu-gen1-smbus gen1, I2C/SMBus > realtek,pse-mcu-gen2 gen2, UART > realtek,pse-mcu-gen2-smbus gen2, I2C/SMBus > realtek,pse-mcu-gen2-i2c gen2, raw I2C > > and each board carries a device-specific compatible that falls back to one > of these, e.g. > > compatible = "zyxel,xs1930-12hp-pse", "realtek,pse-mcu-gen2-smbus"; > > The naming is the part most likely to raise questions, so the reasoning up > front (the binding documents it too): > > - The node describes the MCU together with its Realtek firmware, not a > PSE chip and not the microcontroller silicon. The PSE chips sit behind > the MCU, never appear on the bus, and are reported by the MCU and > detected at runtime; the microcontroller itself is a general-purpose > part (GigaDevice, Nuvoton, ...) that varies across boards. What is > fixed and Realtek's is the firmware and its host protocol - hence the > 'realtek' prefix. > > - gen1 and gen2 are two generations of that protocol, both Realtek's: > gen1 on older boards fronting Broadcom PSE silicon, gen2 the altered > protocol used once Realtek shipped their own PSE silicon. The > generation is fixed per board and is all the driver needs at DT-parse > time, so the compatible encodes it. > > - On I2C the MCU firmware expects one of two framings - SMBus or raw > I2C - which is a genuine programming-model difference, so it is part > of the compatible ('-smbus' / '-i2c'). A UART attachment carries no > framing suffix; the transport is given structurally by the parent > 'serial' node. > > - Each board additionally carries a device-specific compatible that > falls back to the protocol one. The driver only ever binds on the > protocol compatible; the device-specific string keeps the binding > specific and reserves a place for a future per-board quirk without > having to retrofit device trees already deployed in the field. > > Testing > ======= > > - Linksys LGS328MPCv2 (RTL8238B, I2C) > - Zyxel GS1900-10HP A1 (BCM59121, UART) > - Zyxel GS1900-10HP B1 (RTL8238B, UART) > - Zyxel GS1920-24HPv2 (BCM59121, SMBus) > - Zyxel XMG1915-10EP (RTL8239C, UART) > - Zyxel XS1930-12HP (RTL8239, SMBus) > Please note the the nipa sashiko instance as a few more low prio comments: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260813222036.873930-1-jelonek.jonas%40gmail.com I think it's better to apply the series as-is and follow-up on such points. Thanks, Paolo