From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jianguo Zhang <jianguo.zhang@mediatek.com>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Biao Huang <biao.huang@mediatek.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188
Date: Mon, 19 Sep 2022 12:06:04 +0200 [thread overview]
Message-ID: <b343e4c7-a247-28b8-3d16-cb7cea7ba36b@linaro.org> (raw)
In-Reply-To: <f72e133e9aec70724702054e5f6a8712b649d34f.camel@mediatek.com>
On 19/09/2022 11:56, Jianguo Zhang wrote:
>> No, this does not justify new entry. You need specific compatible,
>> but
>> not new entry.
>>
>>> On the other hand, mt8188 and mt8195 have same ethernet design, so
>>> the
>>> private data "mt8195_gmac_variant" can be resued to reduce
>>> redundant
>>> info in driver.
>>
>> And you do not need new entry in the driver.
> Do you mean that I can use "mediatek,mt8195-gmac" as compatible for
> ethernet in mt8188 DTS file?
Yes, as a fallback. Example schema describes such case.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-19 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 8:04 [PATCH 0/2] Mediatek ethernet patchs " Jianguo Zhang
2022-09-19 8:04 ` [PATCH 1/2] stmmac: dwmac-mediatek: add support " Jianguo Zhang
2022-09-19 8:19 ` Krzysztof Kozlowski
2022-09-19 8:37 ` Jianguo Zhang
2022-09-19 9:27 ` Krzysztof Kozlowski
2022-09-19 9:56 ` Jianguo Zhang
2022-09-19 10:06 ` Krzysztof Kozlowski [this message]
2022-09-20 2:33 ` Jianguo Zhang
2022-09-19 8:04 ` [PATCH 2/2] net: dt-bindings: dwmac: " Jianguo Zhang
2022-09-19 8:20 ` Krzysztof Kozlowski
2022-09-19 16:24 ` Krzysztof Kozlowski
2022-09-20 2:41 ` Jianguo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b343e4c7-a247-28b8-3d16-cb7cea7ba36b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jianguo.zhang@mediatek.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®