From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbeEQIMi (ORCPT ); Thu, 17 May 2018 04:12:38 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:60711 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbeEQIMf (ORCPT ); Thu, 17 May 2018 04:12:35 -0400 Subject: Re: [PATCH 1/3] ARM: dra762: hwmod: Add MCAN support To: Tony Lindgren CC: , , , , , , , , References: <1523181542-3770-1-git-send-email-faiz_abbas@ti.com> <1523181542-3770-2-git-send-email-faiz_abbas@ti.com> <20180501152615.GB98604@atomide.com> <20180515171459.GP98604@atomide.com> <20180515171808.GR98604@atomide.com> <20180515172324.GS98604@atomide.com> From: Faiz Abbas Message-ID: Date: Thu, 17 May 2018 13:43:48 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180515172324.GS98604@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, On Tuesday 15 May 2018 10:53 PM, Tony Lindgren wrote: > * Tony Lindgren [180515 17:20]: >> * Tony Lindgren [180515 17:17]: >>> * Faiz Abbas [180515 06:05]: >>>> Hi Tony, >>>> >>>> On Tuesday 01 May 2018 08:56 PM, Tony Lindgren wrote: >>>>> Hi, >>>>> >>>>> * Faiz Abbas [180408 09:59]: >>>>>> From: Lokesh Vutla >>>>>> >>>>>> Add MCAN hwmod data and register it for dra762 silicons. >>>>>> >>>>>> Signed-off-by: Lokesh Vutla >>>>>> Signed-off-by: Faiz Abbas >>>>>> --- >>>>>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 32 +++++++++++++++++++++++++++++++ >>>>>> 1 file changed, 32 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>>>>> index 62352d1..a2cd7f8 100644 >>>>>> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>>>>> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>>>>> @@ -1356,6 +1356,29 @@ static struct omap_hwmod dra7xx_mailbox13_hwmod = { >>>>>> }; >>>>>> >>>>>> /* >>>>>> + * 'mcan' class >>>>>> + * >>>>>> + */ >>>>>> +static struct omap_hwmod_class dra76x_mcan_hwmod_class = { >>>>>> + .name = "mcan", >>>>>> +}; >>>>> >>>>> Looks like you're missing the related struct omap_hwmod_class_sysconfig >>>>> entry for this with the rev and sysconfig registers. >>>>> >>>> >>>> Sorry, I missed this email earlier. The MCAN module doesn't have >>>> sysconfig registers. >>> >>> If there's no sysconfig register you should have no need for adding >>> anything to omap_hwmod_7xx_data.c. We now have the dts clkctrl >>> clocks, you can just add that to the dts node for the device. >> >> However.. My guess is there is somewhere a top level interconnect >> target module that uses DRA7XX_CM_WKUPAON_ADC_CLKCTRL. And that >> module may have multiple child devices. > > And I'm guessing the top level module with sysconfig related > registers is named "adc" :) > Yes. The MCAN clocks are controlled by the ADC_CLKCTRL register. Please see TRM: http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=spruie9&fileType=pdf page: 1530 Thanks, Faiz