From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7585134D4F9 for ; Fri, 6 Mar 2026 09:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772791135; cv=none; b=qMXJqsRR52mIYUvgC3ag//ESRge/m+lH0Z4uQmj9ifbodLwaGCVlTRANXzN1u5NQlKrJpAMqXq+2vijhW09tGfvdlNfoSYHvJoZb6gtVmdNyRtKT8KILsL/vhXmaRcnuxAD3E7YbZx9l/DKqLPVz0gOtz8P77OfbsOFbHXQNemY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772791135; c=relaxed/simple; bh=P0IkSeqQ7fCQIGnFk3lw3TNS81NHlXKUzK61UgqZNFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UnEmL0Qh+/BBqA6P0Qv5FCHwcMzS+KIMAJZrRe+LUce0Ffdwd+IL+ujtlX+W9tg3zIwfPuPNu0lns4cie59Ryr10eHG9cwuvj6k6MilIDkYxwlzyX0KMPCDcIGVkwvV5VY4FNXZY2xP4fdJM1FGZTWYEya1cCpwWENiFKIIVj9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Xk6vWkNZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=CxdhXeYY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Xk6vWkNZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=CxdhXeYY; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Xk6vWkNZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="CxdhXeYY"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Xk6vWkNZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="CxdhXeYY" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3935A5BD8E; Fri, 6 Mar 2026 09:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772791127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhMcktw3Gz3DMzPYzGWkb8un5tONzEZ2V5rvxzmHAIc=; b=Xk6vWkNZ422rV3iMi4Ve6Qn1ufBJgdErdesucNVMM9yzQarWLRCGa/+9kS1MdgB3BQb2WE lYOBoeALVrkQrLUkdTqBATvEXSKCm70vl/XjrBfd6CbTor/Me4UCkeW8lX01rCFAFg9Nbl 0D/5ojq3CZV8z/4LSnrGsu0WZR6/dwI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772791127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhMcktw3Gz3DMzPYzGWkb8un5tONzEZ2V5rvxzmHAIc=; b=CxdhXeYYUMVzJ7txBMqnAinrsNWft+/4ku0Y3SBGnzauNTJYoQJhzlHda+fFQ6bli6PJK9 GXiA5/e3XmN5NRBg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Xk6vWkNZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CxdhXeYY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772791127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhMcktw3Gz3DMzPYzGWkb8un5tONzEZ2V5rvxzmHAIc=; b=Xk6vWkNZ422rV3iMi4Ve6Qn1ufBJgdErdesucNVMM9yzQarWLRCGa/+9kS1MdgB3BQb2WE lYOBoeALVrkQrLUkdTqBATvEXSKCm70vl/XjrBfd6CbTor/Me4UCkeW8lX01rCFAFg9Nbl 0D/5ojq3CZV8z/4LSnrGsu0WZR6/dwI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772791127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhMcktw3Gz3DMzPYzGWkb8un5tONzEZ2V5rvxzmHAIc=; b=CxdhXeYYUMVzJ7txBMqnAinrsNWft+/4ku0Y3SBGnzauNTJYoQJhzlHda+fFQ6bli6PJK9 GXiA5/e3XmN5NRBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD6FB3EA75; Fri, 6 Mar 2026 09:58:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id raUgK1WlqmlMEwAAD6G6ig (envelope-from ); Fri, 06 Mar 2026 09:58:45 +0000 Message-ID: Date: Fri, 6 Mar 2026 10:58:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 2/3] bpf: bpf_out_neigh_v6: Fix nd_tbl NULL dereference when IPv6 is disabled To: Jakub Kicinski , =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= Cc: Martin KaFai Lau , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , David Ahern , Jay Vosburgh , Andrew Lunn , Hangbin Liu , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260305-net-nd_tbl_fixes-v3-0-fde28b30a744@suse.com> <20260305-net-nd_tbl_fixes-v3-2-fde28b30a744@suse.com> <20260305182521.0ca7313c@kernel.org> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260305182521.0ca7313c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[26]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux.dev,iogearbox.net,gmail.com,fomichev.me,kernel.org,google.com,davemloft.net,redhat.com,jvosburgh.net,lunn.ch,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[netdev]; DKIM_TRACE(0.00)[suse.de:+]; R_RATELIMIT(0.00)[to_ip_from(RLjnappfs4fazzqxz8xagywz8p)]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid] X-Rspamd-Queue-Id: 3935A5BD8E X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: On 3/6/26 3:25 AM, Jakub Kicinski wrote: > On Thu, 05 Mar 2026 18:29:56 -0300 Ricardo B. Marlière wrote: >> +++ b/net/core/filter.c >> @@ -2228,6 +2228,9 @@ static int bpf_out_neigh_v6(struct net *net, struct sk_buff *skb, >> return -ENOMEM; >> } >> >> + if (unlikely(!ipv6_stub->nd_tbl)) >> + goto out_drop; > > So neither Fernando nor you checked whether this code can be built > as a module? ipv6_mod_enabled() should work just fine > I checked it. If IPV6=m this is not fine. ld: vmlinux.o: in function `bpf_out_neigh_v6': filter.c:(.text+0x3231d60): undefined reference to `ipv6_mod_enabled' > SMH