From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3627B3EBF29 for ; Tue, 3 Feb 2026 11:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770116815; cv=none; b=jDoljKBuTWRcXc2rGQDewe8h2xW4h4BsGA602AlJlad2xt/M3EATMtlVJFurMSUXOiiO/KCaEa5Ftj8q6FB8y9S0ZQwItC0SWlhmPN4kpU0tGJINhwCfWXpyansmWkqdKwZsH7XxH06F5fEu/q3eVQLE7s+foRmBWJf25XBNPVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770116815; c=relaxed/simple; bh=RUHb0hmdbK4yuWEO6j9gVk0CbEUSL7BqEIrk3+vvT00=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CsmjIokIs8UcVkqnFp8aLcPPz7PflWH/kVDBozcwV92AfExftfPv15NCd7PWStT4OjC0OC1OQ1E0IH7mm6rZLw37F4OXkm4mysfYG8z3up0hQNmZ8nvImtnAqm4aWyJwMYvldmWxXcTUCJIPBr7KXmfpl6if+OVCvP7kcLqUEr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b+5uq2a5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WM7GzQsS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b+5uq2a5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WM7GzQsS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770116813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8EnBfBF6ncrVF3ITSzGDAM65zKqLHl8wgFMMouqTe84=; b=b+5uq2a5RnDlfkxd7xeFgL6y79CfB7rExmNeOhw7R9X1u72XbkxK8dqfF6wCTu6Bvm5jFw r4h20mlaGj71bWSlpSow9A50eoe3Xj0jtWEdc6XNdJqzkxXHmlvDokicmBGY4qU6FPzAlw Rz0wOpnUB/HCl8S4WsNxLcX676Z1gTQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-zyXeNhW5O1uPZ5C8YWVOnQ-1; Tue, 03 Feb 2026 06:06:52 -0500 X-MC-Unique: zyXeNhW5O1uPZ5C8YWVOnQ-1 X-Mimecast-MFC-AGG-ID: zyXeNhW5O1uPZ5C8YWVOnQ_1770116811 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4359d70faa2so3354897f8f.1 for ; Tue, 03 Feb 2026 03:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770116811; x=1770721611; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=8EnBfBF6ncrVF3ITSzGDAM65zKqLHl8wgFMMouqTe84=; b=WM7GzQsSHzbKvU6VhBvdyHetzYgaxgG+MXk8cHj8gyPclQDzw6SQ34ffYMhr6qaOoj TxfHkQWTtTHQNtkdmeZ2F8PXaEGkTqI2MJF5+ZPqsYUT1fE1fN+geFbbO3b3JfoOTBfm CQ9NluXfGA5c3xiABAwIm4jIilZ8D3b+rowXbsJ7KdA18bfdnFWUe2PFmQnyzgyIUi/G z4YSxHRMWT4v0lu5002N/+JdKn6hBQOuYxdHk9tOBHgzmuCtEzzfyB60pPCtPA09qQrP 9C29VDge9BIDqmu0olhdqCm8lwfLyQK5MKjXWJKkK4OQXwURbnAgz8U3bJAxf8uvxkTY B0PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770116811; x=1770721611; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8EnBfBF6ncrVF3ITSzGDAM65zKqLHl8wgFMMouqTe84=; b=MKNg7E5BnKAjMo2JLQ95kC+WiBx93cGcdrtv53HgCYG6zNbF54eNixyQLMZZjKaLSW DRRWALMgODk3EGJrQFT9H/B9TCmv6sUigazZhkTNcIbcTgJDYCIP5eZ3zI2IPAFMMBle H1Ix2IMHu1RNqIsVpIFSUYBVMPyUjl+GqITp1nksoZ66bg4MsmC83FQ9LMCfozpl2szC ZbDZ5B7FjNdfboJfKNWEztcyFpR7iTeA9e2GfGBlt4XIr9S7r9R2oHuwWCwc8JpEQZT6 1FDz3/dxasced+oH/TcZMTgxmT2P1qAkcc+z/7Zyop+S2Q2Y3uax8Fe29evwz0vJqIek 4xBQ== X-Forwarded-Encrypted: i=1; AJvYcCUDVSNZxf+FseCC1lwlEVbay6Y1a+m0uzZzNxDzgY8aeyw7RYNmaTXFjIZBXuK/XKbxCKCZb+EZ+zZYa2k=@vger.kernel.org X-Gm-Message-State: AOJu0YxOw3/9hQQLYyJKazT8Ghez/ZZtx67UTojooPWkj1usE7FYUcW+ bPwQzM5CzvAXLNkrfaWRJfZdxX1zgHxxRWjS9A39vHJ14RgWnOQQOPWOlFw9F54Q5B6mI1eOp8I u30e97sYiugvuq08ydlbBRDMeuwhlOabIyRth8mh2ePsRaeUWFXJX+rFk0HHehXwMRQ== X-Gm-Gg: AZuq6aJLSZHU7YRZa1gukCupCZHB9rEgyLeTNt0z/8Ep5bPrUcDeRMNJcdDsg321pyZ TJjsmrlqMPo5+/ZkkopgE0oKct/xsZcRirQHv+GVKbDxYHQPN2zamJ5jOL1uBWWhcqMcxFrENrl 3itqLwJK8owygJjb3w1OR8whMvBy02+5T6a+473wEhOQSIaZS1OZHcEZYx5F2j5ohGetQyeQ80X w0nAy1UgwfSEP+hyfzuTkI/7uGa7kifFg85Tw36jxLVt7NEOCeYv3b3/xO3cTjtyPQleuoTn77N XvTkqPwzhfK0xHllv5C3V+QKxJT6TAw5IGYY3CsHt1szP4aQjfs4FGxpWIsBndyalBdPBOMgOP6 CLVOGCXr4o93vBfFUrWIGgH7uZnYXkOhzP3Pz7DWlkqGlgVq2qUtc0P1Ot5bLQaEH9kldtftwcz dpH+lcvB1H X-Received: by 2002:a5d:5f82:0:b0:431:266:d134 with SMTP id ffacd0b85a97d-435f3ab2f8bmr24609447f8f.53.1770116810818; Tue, 03 Feb 2026 03:06:50 -0800 (PST) X-Received: by 2002:a5d:5f82:0:b0:431:266:d134 with SMTP id ffacd0b85a97d-435f3ab2f8bmr24609405f8f.53.1770116810370; Tue, 03 Feb 2026 03:06:50 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e135422csm53330238f8f.40.2026.02.03.03.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:06:49 -0800 (PST) Message-ID: Subject: Re: [PATCH v5 09/15] sched: Add task enqueue/dequeue trace points From: Gabriele Monaco To: Peter Zijlstra Cc: K Prateek Nayak , Tomas Glozar , Clark Williams , John Kacur , linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Ingo Molnar , linux-trace-kernel@vger.kernel.org Date: Tue, 03 Feb 2026 12:06:48 +0100 In-Reply-To: <20260122155500.362683-10-gmonaco@redhat.com> References: <20260122155500.362683-1-gmonaco@redhat.com> <20260122155500.362683-10-gmonaco@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Peter, On Thu, 2026-01-22 at 16:54 +0100, Gabriele Monaco wrote: > From: Nam Cao >=20 > Add trace points into enqueue_task() and dequeue_task(). Can I have an Ack for these tracepoints? Thanks, Gabriele >=20 > Suggested-by: Peter Zijlstra > Signed-off-by: Nam Cao > Reviewed-by: K Prateek Nayak > Signed-off-by: Gabriele Monaco > --- >=20 > Notes: > =C2=A0=C2=A0=C2=A0 V5: > =C2=A0=C2=A0=C2=A0 * Do not fire enqueue tracepoint for delayed enqueues >=20 > =C2=A0include/trace/events/sched.h | 13 +++++++++++++ > =C2=A0kernel/sched/core.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | 10 +++++++++- > =C2=A0kernel/sched/sched.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 2 ++ > =C2=A03 files changed, 24 insertions(+), 1 deletion(-) >=20 > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > index 366b2e8ec40c..f4e1d3554e3e 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -912,6 +912,19 @@ DECLARE_TRACE(sched_dl_server_stop, > =C2=A0 TP_PROTO(struct sched_dl_entity *dl_se, int cpu), > =C2=A0 TP_ARGS(dl_se, cpu)); > =C2=A0 > +/* > + * The two trace points below may not work as expected for fair tasks du= e > + * to delayed dequeue. See: > + * https://lore.kernel.org/lkml/179674c6-f82a-4718-ace2-67b5e672fdee@amd= .com/ > + */ > +DECLARE_TRACE(sched_enqueue, > + TP_PROTO(struct task_struct *tsk, int cpu), > + TP_ARGS(tsk, cpu)); > + > +DECLARE_TRACE(sched_dequeue, > + TP_PROTO(struct task_struct *tsk, int cpu), > + TP_ARGS(tsk, cpu)); > + > =C2=A0#endif /* _TRACE_SCHED_H */ > =C2=A0 > =C2=A0/* This part must be outside protection */ > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index f6293fa02fb7..c885d7885172 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -2087,6 +2087,9 @@ unsigned long get_wchan(struct task_struct *p) > =C2=A0 > =C2=A0void enqueue_task(struct rq *rq, struct task_struct *p, int flags) > =C2=A0{ > + if (trace_sched_enqueue_tp_enabled() && !(flags & ENQUEUE_DELAYED)) > + trace_sched_enqueue_tp(p, rq->cpu); > + > =C2=A0 if (!(flags & ENQUEUE_NOCLOCK)) > =C2=A0 update_rq_clock(rq); > =C2=A0 > @@ -2114,6 +2117,8 @@ void enqueue_task(struct rq *rq, struct task_struct= *p, > int flags) > =C2=A0 */ > =C2=A0inline bool dequeue_task(struct rq *rq, struct task_struct *p, int = flags) > =C2=A0{ > + int ret; > + > =C2=A0 if (sched_core_enabled(rq)) > =C2=A0 sched_core_dequeue(rq, p, flags); > =C2=A0 > @@ -2131,7 +2136,10 @@ inline bool dequeue_task(struct rq *rq, struct > task_struct *p, int flags) > =C2=A0 */ > =C2=A0 uclamp_rq_dec(rq, p); > =C2=A0 rq->queue_mask |=3D p->sched_class->queue_mask; > - return p->sched_class->dequeue_task(rq, p, flags); > + ret =3D p->sched_class->dequeue_task(rq, p, flags); > + if (trace_sched_dequeue_tp_enabled() && !(flags & DEQUEUE_SLEEP)) > + trace_sched_dequeue_tp(p, rq->cpu); > + return ret; > =C2=A0} > =C2=A0 > =C2=A0void activate_task(struct rq *rq, struct task_struct *p, int flags) > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index e885a935b716..8465472b40fa 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -2918,6 +2918,8 @@ static inline void sub_nr_running(struct rq *rq, > unsigned count) > =C2=A0 > =C2=A0static inline void __block_task(struct rq *rq, struct task_struct *= p) > =C2=A0{ > + trace_sched_dequeue_tp(p, rq->cpu); > + > =C2=A0 if (p->sched_contributes_to_load) > =C2=A0 rq->nr_uninterruptible++; > =C2=A0