From: Markus Elfring <Markus.Elfring@web.de>
To: "Ma Ke" <make24@iscas.ac.cn>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Alex Hung" <alex.hung@amd.com>, "Alvin Lee" <Alvin.Lee2@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Dillon Varone" <dillon.varone@amd.com>,
"George Shen" <george.shen@amd.com>,
"Hamza Mahfooz" <hamza.mahfooz@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Jun Lei" <jun.lei@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Wenjing Liu" <wenjing.liu@amd.com>,
"Xinhui Pan" <Xinhui.Pan@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Hersen Wu <hersenxs.wu@amd.com>,
Natanel Roizenman <natanel.roizenman@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
Tom Chung <chiahsuan.chung@amd.com>
Subject: Re: [PATCH] drm/amd/display: Check pipe_ctx before it is used
Date: Mon, 24 Jun 2024 21:26:50 +0200 [thread overview]
Message-ID: <b3492198-5345-4bb6-ba89-5efed7ee2440@web.de> (raw)
In-Reply-To: <8d9791ba-14cf-481f-8964-341880865a0a@web.de>
>> resource_get_otg_master_for_stream() could return NULL, we
>> should check the return value of 'otg_master' before it is
>> used in resource_log_pipe_for_stream().
>
> A similar fix was integrated already according to a contribution
> by Natanel Roizenman.
> From which Linux version did you take source files for your static code analyses?
>
> Please take another look at the corresponding software update.
> [PATCH 16/37] drm/amd/display: Add null check in resource_log_pipe_topology_update
> https://lore.kernel.org/amd-gfx/20240422152817.2765349-17-aurabindo.pillai@amd.com/
How “interesting” is it that a similar source code correction needed
to be repeated by Hersen Wu?
drm/amd/display: Add otg_master NULL check within resource_log_pipe_topology_update
https://lore.kernel.org/amd-gfx/20240501071651.3541919-31-chiahsuan.chung@amd.com/
Regards,
Markus
prev parent reply other threads:[~2024-06-24 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 2:48 Ma Ke
2024-06-24 17:16 ` Markus Elfring
2024-06-24 19:26 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3492198-5345-4bb6-ba89-5efed7ee2440@web.de \
--to=markus.elfring@web.de \
--cc=Alvin.Lee2@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dillon.varone@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.shen@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=jun.lei@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=natanel.roizenman@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®