From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbdHLUMt (ORCPT ); Sat, 12 Aug 2017 16:12:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35124 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbdHLUMr (ORCPT ); Sat, 12 Aug 2017 16:12:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 21DA480484 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH 3/4] platform/x86: peaq-wmi: Evaluate wmi method with instance number 0x0 To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Corentin Chary , Darren Hart , Andy Shevchenko Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1502523858-25716-1-git-send-email-pali.rohar@gmail.com> <1502523858-25716-4-git-send-email-pali.rohar@gmail.com> From: Hans de Goede Message-ID: Date: Sat, 12 Aug 2017 22:12:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502523858-25716-4-git-send-email-pali.rohar@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 12 Aug 2017 20:12:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12-08-17 09:44, Pali Rohár wrote: > According to Hans de Goede, WMI interface of thh peaq-wmi module has 10 > instances but corresponding ACPI WMBC method does not check Arg0 (instance > number) at all. Therefore evaluate WMI method with first instance number > (0x0) instead of second (0x1). > > Signed-off-by: Pali Rohár > Cc: Hans de Goede Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/peaq-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c > index 77d1f90..f59a5a2 100644 > --- a/drivers/platform/x86/peaq-wmi.c > +++ b/drivers/platform/x86/peaq-wmi.c > @@ -39,7 +39,7 @@ static void peaq_wmi_poll(struct input_polled_dev *dev) > struct acpi_buffer input = { sizeof(dummy), &dummy }; > struct acpi_buffer output = { sizeof(obj), &obj }; > > - status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 1, > + status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 0, > PEAQ_DOLBY_BUTTON_METHOD_ID, > &input, &output); > if (ACPI_FAILURE(status)) >