From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5AFC43334 for ; Tue, 4 Sep 2018 14:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0ABC820867 for ; Tue, 4 Sep 2018 14:51:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="b7fz1Hw1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ABC820867 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbeIDTQW (ORCPT ); Tue, 4 Sep 2018 15:16:22 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:58946 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbeIDTQW (ORCPT ); Tue, 4 Sep 2018 15:16:22 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id w84EopA7061519; Tue, 4 Sep 2018 09:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1536072651; bh=GD70eLShr0kbUnZyv0kF0S1wM0Os00zaK2I6DgQQzsk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=b7fz1Hw1e25peDr/BIwWKU6pbSI6+XWGhwnBW/gDNRHPoLN2t2+bwYUEFi9N/rfGo LdxoOLp+oOPdCyyzxgvVU+lW44TpC18X6w5mhi2TTmx4ll6evMBe7ggh2evJOUW685 tgyKEhhs75pXEabj5kfQ40Mc0FMgaIMrcXFPrC1w= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w84EopwF031825; Tue, 4 Sep 2018 09:50:51 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 4 Sep 2018 09:50:51 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Tue, 4 Sep 2018 09:50:51 -0500 Received: from [172.22.184.106] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w84EoofP007425; Tue, 4 Sep 2018 09:50:50 -0500 Subject: Re: [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling To: Mark Brown CC: Liam Girdwood , , References: <20180831181737.29516-1-afd@ti.com> <20180903113038.GG10302@sirena.org.uk> From: "Andrew F. Davis" Message-ID: Date: Tue, 4 Sep 2018 09:50:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180903113038.GG10302@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/2018 06:30 AM, Mark Brown wrote: > On Fri, Aug 31, 2018 at 01:17:37PM -0500, Andrew F. Davis wrote: >> The notification handler sets the reset line but never re-enables it >> as no one is listening for an enable event, this is certainly broken >> and was most likely just copied from other CODECs, remove this code. > > Why not fix it? The usual pattern would be to take the CODEC out of > reset when bringing the bias back to standby. > The only time this code gets called outside of the normal power on/off path is regulator_force_disable(). And the enable event is only called inside regulator_enable() which would already be part of the normal power up path. I still don't see the need for this code at all, I do not want to fix unused broken code, and if no one else will fix it, the code should be dropped.